Repository navigation
Conversation
Collaborator
Author
|
Rebased onto origin/main (83ee34e). Every conflict was against main's own copy of this refactor: main already has HasInlineOption in destinations/inline_option.go and the shared isBarePath, and license.ConfiguredKeys replaces CollectAllKeys. I took main's side and dropped the duplicates (the extra HasInlineOption in stream.go, keys_all.go), so the branch now equals main and the PR diff is empty. Tests pass on this tree (repoqa, backup, license, cmd/commands). Nothing left to merge here; close the PR unless more work is intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #971 (D-1156, D-1170),
TestPackageSizeBudgetfailed on main and every PR:cmd/commands has 65379, ceiling is 65362; internal/backup has 6290, ceiling is 6279.Reproduced on a clean origin/main (d49096b) before changing anything.
Fix (no ceiling raised, ratchet file untouched)
internal/backup/destinations: newHasInlineOption(the,key=regexp and the./,../exemption), used byisBarePath.internal/license: newCollectAllKeysinkeys_all.go(kept out ofkeys.gobecause of the 300-line file cap).templateLicenseKeysincmd/commandsis nowvar templateLicenseKeys = license.CollectAllKeys.TestHasInlineOption.Verified
go build ./...go vet ./cmd/commands ./internal/backup/... ./internal/license/gofmt -l cmd internal(clean)go test -count=1 ./internal/repoqa/(includesTestPackageSizeBudgetand the file-size cap)go test -count=1 ./internal/backup/... ./internal/license/...go test -count=1 ./cmd/commands/ -run 'Template|Clone|Init'