Skip to content

fix(cli): get cmd/commands and internal/backup back under the package-size ceiling - #974

Closed
acamarata wants to merge 0 commit into
mainfrom
dw5-cli-1
Closed

acamarata wants to merge 0 commit into
mainfrom
dw5-cli-1

Conversation

@acamarata

@acamarata acamarata commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

After #971 (D-1156, D-1170), TestPackageSizeBudget failed on main and every PR:
cmd/commands has 65379, ceiling is 65362; internal/backup has 6290, ceiling is 6279.
Reproduced on a clean origin/main (d49096b) before changing anything.

Fix (no ceiling raised, ratchet file untouched)

  • internal/backup/destinations: new HasInlineOption (the ,key= regexp and the ./, ../ exemption), used by isBarePath.
  • internal/license: new CollectAllKeys in keys_all.go (kept out of keys.go because of the 300-line file cap). templateLicenseKeys in cmd/commands is now var templateLicenseKeys = license.CollectAllKeys.
  • A few comment lines tightened. Behaviour is unchanged.
  • Added TestHasInlineOption.

Verified

  • go build ./...
  • go vet ./cmd/commands ./internal/backup/... ./internal/license/
  • gofmt -l cmd internal (clean)
  • go test -count=1 ./internal/repoqa/ (includes TestPackageSizeBudget and the file-size cap)
  • go test -count=1 ./internal/backup/... ./internal/license/...
  • go test -count=1 ./cmd/commands/ -run 'Template|Clone|Init'

@acamarata

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/main (83ee34e). Every conflict was against main's own copy of this refactor: main already has HasInlineOption in destinations/inline_option.go and the shared isBarePath, and license.ConfiguredKeys replaces CollectAllKeys. I took main's side and dropped the duplicates (the extra HasInlineOption in stream.go, keys_all.go), so the branch now equals main and the PR diff is empty. Tests pass on this tree (repoqa, backup, license, cmd/commands). Nothing left to merge here; close the PR unless more work is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant