Repository navigation
Conversation
The test divided work for 10x input by a 4 KB reading that is 0s on Windows (coarse timer), so any nonzero large reading failed. Time batches of at least 3 ms per size, take the best of five, compare per-call cost with a 40x bound plus a 200 us floor. A 100x quadratic regression still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TestSchemelessLinear(internal/credmask/linear_test.go, added in #979) failed on windows-2022 (run 40440673969):unit "@a(": 4000 B took 0s, 40000 B took 2.5518ms: not linear. Windows timers are coarse, so the small input read as 0s and the50*prev + 2msbound broke. The masking code is fine.Note: the test lives in
internal/credmask, notinternal/config;config.MaskURLCredentialsdelegates to it.config's ownTestMaskURLCredentialsLinearalready has a 250 ms floor and was not changed.Change (test only)
A counter-based deterministic check would need production instrumentation, so I kept it timing-based.
Verified (darwin host)
go test -count=20 -run TestSchemelessLinear ./internal/credmask: ok (25.6 s)GOOS=windows go vet ./internal/credmask ./internal/config: clean;GOOS=windows go test -c: compilesgo test -count=1 ./internal/config ./internal/credmask: ok@proto(match inmaskDSNUserinfo: test FAILED (e.g."@a(": 40000 B took 6.2ms/call, 400000 B took 377ms/call); reverted, not in this PR.