Skip to content

fix(truth): clear retired-term findings - #206

Closed
acamarata wants to merge 1 commit into
mainfrom
truth-nchat-20261023
Closed

acamarata wants to merge 1 commit into
mainfrom
truth-nchat-20261023

Conversation

@acamarata

@acamarata acamarata commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Replace the cancelled product in live RBAC documentation and SQL/TypeScript comments with a generic Example App. Keep the guides’ example IDs, paths, and repository setup consistent. Runtime code and SQL statements are unchanged; archives, planning documents, ADRs, and changelogs are untouched.

Validation:

  • Case-insensitive git grep -niE "ɳTV|flutter sdk" with the requested exclusions: no matches.
  • git diff --check: passed.
  • pnpm --filter @nself-chat/web lint: passed (existing warnings).
  • pnpm --filter @nself-chat/web type-check: passed.
  • pnpm --filter @nself-chat/web test: 650 suites passed, 4 failed, 56 skipped; 32,441 tests passed, 6 failed, 2,291 skipped. All six failures reproduce in a detached checkout of the unchanged parent commit:
    • subscription-state-machine.test.ts: renewal date expectation.
    • data-deletion.service.test.ts: grace-period date expectations.
    • reduced-motion.test.ts: deleting non-configurable matchMedia.
    • device-fingerprint.test.ts: date expectation.
  • Verified executable SQL and TypeScript are identical after stripping comments.

@acamarata

Copy link
Copy Markdown
Collaborator Author

Folded into #205 (same branch, so one review lands both and the checks of #205 cover the combined tree). The commit is unchanged.

@acamarata acamarata closed this Oct 23, 2026
@github-actions

Copy link
Copy Markdown

PR Checks Summary

Check Status
Lint & Format ✅ success
Type Check ✅ success
Unit Tests ❌ failure
Build ✅ success

❌ Some checks failed. Please review the errors above.

@acamarata
acamarata deleted the truth-nchat-20261023 branch October 23, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant