Repository navigation
test(a11y): reduced-motion tests no longer delete a non-configurable matchMedia - #212
Merged
Merged
Conversation
…up defines it non-configurable, so delete threw)
Security Scan Results: PASSED
|
PR Checks Summary
✅ All checks passed! Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests in src/lib/a11y/tests/reduced-motion.test.ts did
delete window.matchMedia, which throws because jest.setup.js defines it non-configurable. They now assign undefined and restore by assignment. The file passes locally (60/60, TZ=America/New_York). This was one of the two reasons the unit-test gate was red on main.