Repository navigation
test(frontend): re-enable stale skipped suites (D-0098, partial) - #214
Merged
Merged
Conversation
…d (D-0098) Un-skips 17 describe blocks across 8 files whose skip reasons (mock updates, BullMQ ESM, hook API mismatch) no longer hold. 208 tests pass; the stale skip comments are removed with them.
Security Scan Results: PASSED
|
PR Checks Summary
❌ Some checks failed. Please review the errors above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-0098 (partial): frontend skipped tests
Row still applies on origin/main: about 226
describe.skip/it.skip/xdescribehits across 89 files underfrontend/src(plus e2e). This PR does the cheap slice only: suites whose skip is stale.What changed
Un-skipped 17 describe blocks in 8 files and removed their stale "Skipped:" comments. No test bodies changed.
Method
Removed every skip in all 89 files, ran each file alone (
jest --maxWorkers=1, 150 s cap,TZ=America/New_York). Result: 9 pass, 78 fail, 1 timed out, 1 aborted (use-search-suggestions,use-attachments: hang / memory, consistent with the recorded "memory issue" reason). Kept the 8 that pass. Reverted the 9th,lib/e2ee/group-session: it passes on local Node 26, but its comment says it fails on CI's Node 20, so I could not verify it here.Not done (row stays open)
About 80 files fail when un-skipped. They need the per-suite classify-and-fix the row describes (real regression / stale mock / delete). The largest groups are
formatter.service(hand-rolledmarked/ DOMPurify mocks insrc/__tests__/mocks), the hooks suites with API mismatch, realtime/webrtc and the 14 e2e skips. None of that is a small single-purpose change. Suggested follow-up: one ticket per suite, plus a lint rule that rejects.skipwithout an issue link.Verification
TZ=America/New_York npx jest --forceExit --maxWorkers=2on the 8 files: 8 suites, 208 tests passed, 0 skipped.eslinton the 8 files: 0 errors (2 existing unused-directive warnings in users-management).prettier --check: clean.