Repository navigation
fix(drill): fail toolchain-pins tool rows without sources (D-1184, D-0112 blocked) - #469
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-1184 (fixed)
scripts/drill/toolchain-pins/runread a tool row'ssourcesthrough a process substitution (done < <(jq -c '.sources[]' ...)).set -euo pipefaildoes not stop a failed process substitution, so a tool row with nosourcesmade jq fail silently, the loop ran zero times and the row passed with nothing checked. The script now readssourcesfirst and emits a failing check ("tool row has no sources to verify") when it is absent or empty.Test:
TestDrillFailsWhenAToolRowHasNoSources(absent and empty cases). Against the old script both cases fail (exit 0, result pass); with the fix they pass.D-0112 (not changed here, blocked on a product decision)
notificationsis already deprecated since v1.1.0 with a migration note in its README and registry description pointing tonotify. No code change needed beyond the formal sunset step.jobsis Postgres-polling, bundletask, port 3105;job-queueis Redis-backed with a DLQ, library service kind, requires nself >=1.0.0). Picking the survivor is a product-scope call, and the registry deprecation entry needs a regenerated, signed registry.json (release flow). Left for the owner.Checks
bash -n scripts/drill/toolchain-pins/run: okcd free/ci && go vet -mod=vendor ./internal/toolchain/: okgo test -mod=vendor ./internal/toolchain/...: okgo test -mod=vendor ./...in free/ci: two failures,cmd/agent TestServeStdioExitsNonZeroWithE663OnAProdStackMarkerandinternal/legacy TestSecretsEnvLiveKeyGateTrackedValueOnly. Both fail identically on a clean origin/main, so they pre-exist.