Skip to content

fix(ci): reject unknown MinTrust in Promotable, budget config pointer bytes (D-1128, D-1172) - #470

Merged
acamarata merged 2 commits into
mainfrom
dw1-plugins-3
Oct 25, 2026
Merged

acamarata merged 2 commits into
mainfrom
dw1-plugins-3

Conversation

@acamarata

@acamarata acamarata commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Rows

  • D-1128 (fixed): authz.Promotable raised any floor ranking below internal to internal, and an unknown MinTrust ranks -1, so a typo'd owner floor was weakened instead of rejected by attest.GateAccept. It now raises only a known floor below internal; an unknown floor passes through and is refused with evidence.trust_below_min. Test TestPromotable_UnknownFloorIsRefused (internal-trust evidence, floors "", "owner ", "Owner", "unknown") fails on main and passes now.
  • D-1136 (already fixed, no change): cirun.ReleaseInputs is registered in free/ci/cmd/build_v15.go:52 (init, added with D-1074 / c7a23aa, feat(ci): nself ci build --artifact android as a V15 release pipeline (P7-CACHE-15) #380), so Bound is no longer nil in the shipped binary. The row's grep missed it because the assignment is through the cirun import alias in cmd.
  • D-1172 (fixed): the config walker kept a full JSON pointer per node in w.lines with no budget. Added maxPtrBytes (16 MiB) charged for each pointer built (map keys and sequence items); over it the existing "too large" problem is reported. Test TestLongKeyPointersAreBudgeted (16 KiB key over 10k items, file under 1 MiB) fails on main (accepted) and passes now.

Commands (free/ci)

  • go build -mod=vendor ./..., go vet -mod=vendor ./...: clean
  • go test -mod=vendor ./...: all packages pass
  • Each new test run against reverted source: fails; with fix: passes

@acamarata
acamarata merged commit c374e59 into main Oct 25, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant