Repository navigation
fix(ci): reject unknown MinTrust in Promotable, budget config pointer bytes (D-1128, D-1172) - #470
Merged
Merged
Conversation
added 2 commits
October 25, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows
authz.Promotableraised any floor ranking belowinternaltointernal, and an unknown MinTrust ranks -1, so a typo'd owner floor was weakened instead of rejected byattest.GateAccept. It now raises only a known floor belowinternal; an unknown floor passes through and is refused withevidence.trust_below_min. TestTestPromotable_UnknownFloorIsRefused(internal-trust evidence, floors"","owner ","Owner","unknown") fails on main and passes now.cirun.ReleaseInputsis registered infree/ci/cmd/build_v15.go:52(init, added with D-1074 / c7a23aa, feat(ci): nself ci build --artifact android as a V15 release pipeline (P7-CACHE-15) #380), soBoundis no longer nil in the shipped binary. The row's grep missed it because the assignment is through thecirunimport alias incmd.w.lineswith no budget. AddedmaxPtrBytes(16 MiB) charged for each pointer built (map keys and sequence items); over it the existing "too large" problem is reported. TestTestLongKeyPointersAreBudgeted(16 KiB key over 10k items, file under 1 MiB) fails on main (accepted) and passes now.Commands (free/ci)
go build -mod=vendor ./...,go vet -mod=vendor ./...: cleango test -mod=vendor ./...: all packages pass