Repository navigation
fix(ci): prune, tool-signature and flaky-annotation fixes (D-1189, D-1192, D-1193) - #471
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, single-purpose fixes in
free/ci. Each was still present on origin/main (c886feb).D-1189 –
internal/history/prune.go: the run-start prune discarded theLoadPolicyerror, so a malformedretention.jsonsilently pruned on the default limits. It now skips the automatic prune and prints a note to stderr (the manualruns prunealready notes and uses defaults on explicit request). Test:TestRunStartSkipsPruneWhenRetentionFileIsBad(fails without the fix).D-1192 –
internal/diagnose/signatures.go: the tool signature's output regex: not found$matchedcustomer: not foundand retried an application failure as infra. It now requires a shell-prefixed line (sh:,/bin/sh:,bash:with optionalline N:/N:). Tests added toTestClassifyClasses(the app message is code; the/bin/sh: line 3:form stays infra). The new app-message case fails without the fix.D-1193 –
internal/flaky/annotate.go,internal/run/flaky_hook.go: notes were keyed by check id only, so a same-named check in another job got the flaky mark. Notes are now keyed bymodel.FlakyKey(jobID, checkID)on both sides. Tests:TestAnnotateKeysByJobAndCheck(flaky) andTestMarkHistoryFlakyMatchesJobAndCheck(run). These use the new helper, so they do not compile without the fix.Commands (in
free/ci):go vet -mod=vendoron touched packages (clean);go test -mod=vendor ./...(all packages ok). Confirmed the D-1189 and D-1192 tests fail with the source change reverted.