Repository navigation
fix(ci): podman image pull and ci logs -f on retryable attempts (D-1185, D-1188) - #475
Merged
Merged
Conversation
added 2 commits
October 25, 2026 11:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows
D-1185 (fixed).
Resolver.ensurehardcodeddockerforimage inspectandpull, andrunContainerhardcodeddocker run. A Podman-only host with a valid pinned image failed with the generic cannot-pull E645. The resolver now tries docker, then podman (a CLI counts as absent on a start error or the shell's exit 127, which is how the exec funnel reports a missing binary).runContainerpicks the same runtime (containerRuntime: docker if installed, else podman) so the pulled image is run by the CLI that pulled it. Tests:TestEnsureFallsBackToPodmanWhenDockerCannotRun,TestBaselineContainerUsesPodmanWhenDockerIsAbsent. Both fail on the old code (E645 "docker: not found"; "E613: docker run: executable file not found").D-1186 (no change). The validated impact (a forwarded host PATH overriding the image PATH) is already fixed on main by #393 (
imageOwnedEnv/containerEnvinfree/ci/internal/exec/envallow.go, testTestBaselineContainerKeepsImagePathAndToolchain). The row title (unpinned aptgcc/libc6-dev,Dockerfile:123) is not addressed: pinning needs a dated apt snapshot or version pins, which changes the image contents and requires a rebuild and publish plus a new digest inversions.yaml. That is a release step, so not done here.D-1188 (fixed).
attemptEndedincmd/logs.golackedretryable, soci logs -fwaited forever on an attempt parked as retryable after a coordinator crash.retryableis added (it is already terminal intransport/agent/gate.go, andlost, which also precedes retryable, was already listed). Test:TestAttemptEndedForParkedAndLiveStates, which fails on the old code.Commands run (free/ci,
-mod=vendor)go build ./...,go vet ./...: cleango test ./...: all packages pass exceptinternal/transport/agentTestPullCoordinatorKillResumesWithoutDuplicates, which failed once under load (package untouched) and passes alone (3/3) and in a full package rerun.image.goandcontainer.gotemporarily: the two new D-1185 tests fail as above.🤖 Generated with Claude Code