Repository navigation
fix(docs,deps): Retro-Gaming CLI wiki, K8s Windows uninstall, tidy all Go modules (D-0670 D-0672 D-0654) - #479
Merged
Merged
Conversation
added 4 commits
October 25, 2026 15:13
… binary is (D-0670)
Contributor
Author
|
Rebased onto origin/main. The only conflict was .github/workflows/build-test.yml: main added a build/vet/test step for the sdk and scripts modules (D-0656), and this PR added a separate tidy-check step over the same modules. Merged into the one step: it now builds, vets, tests, then runs go mod tidy -diff. The tidy check for free/ plugins is unchanged. Checked that every Go module (free, sdk, scripts) passes go mod tidy -diff after the rebase, and the workflow YAML parses. |
acamarata
force-pushed
the
dw2-plugins-1
branch
from
October 25, 2026 19:13
28d2008 to
2d49cd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows
D-0670 Retro-Gaming wiki: the "CLI Commands" section is replaced by "Running the Service". The binary has no subcommands, so the section now lists
/healthand/readyand the/api/v1/*resource routescmd/main.goregisters. Quick Start no longer callsinit,serverorroms list, and thecores seedtroubleshooting line now says to create cores withPOST /api/v1/emulator-cores.free/retro-gaming/README.mdhas no CLI mentions, so it is unchanged. The plugin seeds no cores. The wiki's REST API section and the manifestapiEndpoints(/api/games/...) do not match the registered routes (/api/v1/...); I noted that in the page but did not rewrite them, because aligning the two is a product decision.D-0672 K8s wiki: one sentence added. Terminal detection exists on Linux and macOS only, so on Windows uninstall needs
--yes. This matchesfree/k8s/cmd/confirm_tty_other.go.D-0629 Already fixed, no change.
.workers/plugins-registry/src/index.jsis gone (replaced byindex.tsin #192) and nothing in the worker setsX-Warning. No header value has a non-ASCII character; the remaining non-ASCII text is in comments, the bundle catalog and aconsole.errorstring.D-0885 Blocked, no change. Four reasons:
scripts/conformance/ports.shrejects that, so someone has to allocate new ports and change the compose fragments, the Dockerfiles and the code defaults.service.portwith the compose fragment andEXPOSEalso flags entitlements, media-processing, meetings, podcast, subtitle-manager and workflows (manifest ports differ from compose andEXPOSE), plus others. Those need the same port decision.D-0654 67 modules were untidy under
go mod tidy -diffwith go1.26.9 andGOWORK=off, more than the 35 listed. I rango mod tidy, andgo mod vendorwherevendor/exists. The go.mod changes are in k8s, sentry-cli and nself-cloud/third_party/shared-utils; the rest are go.sum. Vendored plugin-sdk README.md and COMPATIBILITY.md also refreshed, because they had drifted fromsdk/.build-test.ymlnow runsgo mod tidy -diffper module underfree/, plus a step forsdk/andscripts/on full runs.Commands run
go mod tidy -diffon all 225 modules, 67 failed. After: 0 failed, including thefind free sdk scriptsloop the workflow now uses.go build,go vet,go test, with-mod=vendorwhere vendored. 66 pass.sdkfailsgo vetonmetrics/metrics_test.go:39("using resp before checking for errors"); that is a pre-existing test-file issue and not in the CI loop.go buildandgo testpass forsdk.build-test.ymlparses as YAML.cores seed,sessions recentorretro-gaming initleft), not by an automated test.🤖 Generated with Claude Code