Skip to content

fix(docs,deps): Retro-Gaming CLI wiki, K8s Windows uninstall, tidy all Go modules (D-0670 D-0672 D-0654) - #479

Merged
acamarata merged 4 commits into
mainfrom
dw2-plugins-1
Oct 26, 2026
Merged

acamarata merged 4 commits into
mainfrom
dw2-plugins-1

Conversation

@acamarata

Copy link
Copy Markdown
Contributor

Rows

D-0670 Retro-Gaming wiki: the "CLI Commands" section is replaced by "Running the Service". The binary has no subcommands, so the section now lists /health and /ready and the /api/v1/* resource routes cmd/main.go registers. Quick Start no longer calls init, server or roms list, and the cores seed troubleshooting line now says to create cores with POST /api/v1/emulator-cores. free/retro-gaming/README.md has no CLI mentions, so it is unchanged. The plugin seeds no cores. The wiki's REST API section and the manifest apiEndpoints (/api/games/...) do not match the registered routes (/api/v1/...); I noted that in the page but did not rewrite them, because aligning the two is a product decision.

D-0672 K8s wiki: one sentence added. Terminal detection exists on Linux and macOS only, so on Windows uninstall needs --yes. This matches free/k8s/cmd/confirm_tty_other.go.

D-0629 Already fixed, no change. .workers/plugins-registry/src/index.js is gone (replaced by index.ts in #192) and nothing in the worker sets X-Warning. No header value has a non-ASCII character; the remaining non-ASCII text is in comments, the bundle catalog and a console.error string.

D-0885 Blocked, no change. Four reasons:

  • The port the process binds collides with another plugin's manifest port. geocoding binds 3203 (nself-geo's manifest port) and github-runner binds 3053 (push's). scripts/conformance/ports.sh rejects that, so someone has to allocate new ports and change the compose fragments, the Dockerfiles and the code defaults.
  • Changing a compose port changes v1.4.12 compose output and needs an oracle delta.
  • Extending the ports rule to compare service.port with the compose fragment and EXPOSE also flags entitlements, media-processing, meetings, podcast, subtitle-manager and workflows (manifest ports differ from compose and EXPOSE), plus others. Those need the same port decision.
  • hipaa is the easy one (manifest, Dockerfile and docs say 3214, the code default says 3212), but I left it so the row lands in one change.

D-0654 67 modules were untidy under go mod tidy -diff with go1.26.9 and GOWORK=off, more than the 35 listed. I ran go mod tidy, and go mod vendor where vendor/ exists. The go.mod changes are in k8s, sentry-cli and nself-cloud/third_party/shared-utils; the rest are go.sum. Vendored plugin-sdk README.md and COMPATIBILITY.md also refreshed, because they had drifted from sdk/. build-test.yml now runs go mod tidy -diff per module under free/, plus a step for sdk/ and scripts/ on full runs.

Commands run

  • Before: go mod tidy -diff on all 225 modules, 67 failed. After: 0 failed, including the find free sdk scripts loop the workflow now uses.
  • For each of the 67 changed modules: go build, go vet, go test, with -mod=vendor where vendored. 66 pass. sdk fails go vet on metrics/metrics_test.go:39 ("using resp before checking for errors"); that is a pre-existing test-file issue and not in the CI loop. go build and go test pass for sdk.
  • build-test.yml parses as YAML.
  • The wiki edits are checked by grep (no cores seed, sessions recent or retro-gaming init left), not by an automated test.

🤖 Generated with Claude Code

@acamarata

Copy link
Copy Markdown
Contributor Author

Rebased onto origin/main. The only conflict was .github/workflows/build-test.yml: main added a build/vet/test step for the sdk and scripts modules (D-0656), and this PR added a separate tidy-check step over the same modules. Merged into the one step: it now builds, vets, tests, then runs go mod tidy -diff. The tidy check for free/ plugins is unchanged. Checked that every Go module (free, sdk, scripts) passes go mod tidy -diff after the rebase, and the workflow YAML parses.

@acamarata
acamarata merged commit 7bff4ec into main Oct 26, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant