Repository navigation
fix(ci,file-processing,media-processing): evidence freshness, policy diagnostics, pnpm install path (D-1123, D-1125, D-1126, D-0623) - #482
Merged
Conversation
…, pnpm 9/10/11 matrix (D-0623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows
D-1123 (fixed).
buildEvidencesetfreshness: currentnext tobinding: unboundfor a dirty tree or a missing commit, which the schema forbids. It now reportsunknownwith a reason, the same asinternal/evidence/build.go. TestTestUnboundEvidenceIsNeverCurrentvalidates the document againstci-evidence.v1; it fails without the fix (freshness "current", schema error).D-1125 (fixed, partly already fixed). The "ignores
Options.Home" half was fixed by #472 (hook opensPolicyRequest.Store). The remaining half was real: only run-scopeIgnoredentries reached the run; protected-branch, pin and revision refusals and a stale fetch were dropped.PolicyResult.Notesnow carries them andconcludeadds them aspolicy: ...notes. Tests:TestPolicyHookReportsBranchDiagnostics,TestPolicyNotesReachSummary,TestPolicyNotes.D-1126 (fixed). The tip-read failure was already reported as E672, but the text said "could not be fetched or read" even when the fetch had succeeded.
Branch.Fetchednow tells the cases apart and the note says "was fetched but its tip could not be read". TestTestFetchedButUnreadableTipIsReportedfails without the resolve.go change.D-0293 (BLOCKED). Porting
free/file-processingandfree/media-processingfrom Rust to Go is a rewrite of two plugin runtimes plus a decision on scope: the row asks to check overlap withfree/storage-transform(no such directory exists;free/storageandfree/object-storagedo), and both plugins also ship a TypeScript implementation underts/that does use sharp/ffmpeg, so which implementation is canonical is an open product call. Not a small single-purpose fix, and it touches the release path (Dockerfiles, Cargo, cargo audit). Related D-0294 and D-0306 are untouched.D-0623 (fixed, CI-comment part stale).
.github/workflows/nself-ci.ymlno longer has any pnpm orfile:text; the gate there is the pinned nself-ci. The stale comment is in the twots/pnpm-workspace.yamlfiles ("GitHub nself-ci workflow ... run pnpm 9"); corrected.free/file-processing/install.shused npm (link:fails with EUNSUPPORTEDPROTOCOL, probed) and swallowed errors with2>/dev/null || plugin_warn. It now installs shared andts/with pnpm, builds, and fails on any error or a missing pnpm.free/media-processinghas no install.sh. Test:free/file-processing/tests/install-ts.test.sh(stub pnpm; install failure, build failure and missing pnpm each return 1).ts-pnpm-matrixjob inbuild.yml: pnpm 9, 10, 11 x both plugins, shared deps installed withshared/distabsent, then install, typecheck, build. I ran all six combinations locally (pnpm 9.15.9, 10.34.8, 11.28.8): install, typecheck and build all exit 0. The workflow itself has not run on GitHub yet.Commands run
cd free/ci && go build -mod=vendor ./... && go vet -mod=vendor ./...: clean.go test -mod=vendor ./internal/run ./internal/policy: 375 passed.go test -mod=vendor ./...: failures incmd/agent(TestServeStdioExitsNonZeroWithE663OnAProdStackMarker) andinternal/legacy(TestSecretsEnvLiveKeyGateTrackedValueOnly) are pre-existing: both fail identically on a clean origin/main worktree.internal/run(TestStatusNotPostedForPartialCancelledOrOutsideConfig),internal/execandagentapifailed once under load and pass on rerun.bash free/file-processing/tests/install-ts.test.sh: 4 ok.