Repository navigation
fix(ci): hosted location and --coordinator flag gaps (D-1402, D-1409) - #485
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows
D-1402 FIXED.
registry.UpdateCapabilitynow takesLocation.Kindandnself.*labels from the stored record unless the actor starts withpolicy:. A node report can no longer make itself hosted (which skips the AuthorizedProjects check insched/eligibility.go), clear a hosted location, or add or replace annself.*label. The burst provider (policy:burst, cloudvmAfterIssue) still sets both, so a blanket "ignore hosted" was not used. Test:TestNodeReportCannotSetHostedOrProviderLabels(fails on main with "a node report made the node hosted").D-1409 FIXED.
lifecycle.AddCoordinatorFlagdeclares--coordinatoronce;nodes setandnodes upgradeflag sets and the existing lifecycle loop use it. Test:TestRoutedNodesFlagSetsListCoordinator(fails on main fornodes setandnodes upgrade). There is no Reference.md in this repo; it is generated from the flag sets, so it needs a regenerate where it lives.D-0188 NOT-REPRODUCED / not triggered. The row says promote at a third copy. Only two exist (cli
internal/observability/redact.goandfree/ci/internal/redact/shapes.go); thesk_live_,xoxb-hits elsewhere in plugins are tests or format checks.sdk/gois in the cli repo anyway.D-0457 BLOCKED. The row defers
accelerator_details[]to a capability minor revision when a scheduler ticket needs it. No such ticket exists in this repo (noaccelerator_detailsanywhere), and it is a capability schema/product-scope change tied to P7-NODE-22.D-0513 BLOCKED. Needs a change in cli
sdk/go/remote(a way to addHostSpec.SSHOptions()to the default BaseOptions; the allowlist refusesStrictHostKeyCheckingin an explicit Options slice), then a re-vendor of a new pinned sdk version. Checked cli origin/main:Targetstill has no such field. Not editable from this repo.Checks (free/ci,
-mod=vendor)go build ./...,go vet ./...: clean.go test -p 4 ./...under load: red incmd/agent(TestServeStdioExitsNonZeroWithE663OnAProdStackMarker) andinternal/legacy(TestSecretsEnvLiveKeyGateTrackedValueOnly); both fail the same on clean origin/main (pre-existing).cmd(10 min timeout),internal/run,internal/exec,providers/doctorwere load flakes: each passes alone on this branch (cmd59s).cmd,internal/nodes/registry,internal/nodes/lifecycle,internal/agent/update,internal/sched: ok.