Repository navigation
refactor(ci): split three files over the 300-line limit (D-1484) - #489
Merged
Merged
Conversation
Move cohesive functions to sibling files with no behaviour change: registry.go -> policy_guards.go + age_recipient.go, github-runner trust.go -> trust_registration.go, verify-published-checksums.sh -> shared functions in verify-published-checksums-lib.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Hygiene
file-sizestep failing on main (D-1484). Pure moves, no behaviour change.free/ci/internal/nodes/registry/registry.go342 -> 249: policy guards (PolicyActorPrefix,keepHostedKind,keepProviderLabels,isolationRank) topolicy_guards.go; age-recipient pinning toage_recipient.go. Same package, same exported API.free/github-runner/internal/trust.go416 -> 270: runner registration/group verification (runnerRef,persistedRunner,verifyRegisteredGroup,listRunners) totrust_registration.go.scripts/verify-published-checksums.sh347 -> 291:fetch_release_assets,upsert_release_row,write_releases_json,report_failuresmoved into the existingverify-published-checksums-lib.sh(no new file, so the test harnesses that copy only the CLI and lib still work).Commands run (all pass):
python3 scripts/ci/check-file-size.py(hygiene.yml file-size step): rc 0 (3 violations before)go vet+go test -mod=vendor ./...infree/ciandfree/github-runner: all okbash scripts/release/verify-published-checksums-test.sh: all cases passedpython3 -m unittest discover -s scripts/ci/tests: 88 tests OKbash .github/scripts/no-attribution-check.sh --all: content scan passedshellcheck is not installed locally, so it was not run (
bash -nis clean).