Repository navigation
fix(ci): redact dash-prefixed secret values (D-1133, D-1483) - #492
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-1133: fixed
Fresh origin/main at f9fc3d1 still skipped values starting with a dash after secret flags. Remove that exclusion so those values are registered for output masking and redacted in recorded argv. Regression coverage checks single/double dash values and the existing warning behavior for short secrets, including recording before registration.
D-1483: blocked
Main f9fc3d1 (#490) already provides the daily free-plugin download/hash freshness gate and investigation. The actual licensed
aimismatch persists: the public registry advertisesd2c8c7345babbb367c42fbef9efa1a91e424b401f36452bdcccb005b686599e6, while the public catalog advertises03071f9d6c13cca200ca43c2c22dc5ad6c9f722c94d388f89e2a55feb9264598. The registry marksaias licensed (tier=max,requires_license=true), and it is absent from this repository's free registry/releases.Repair requires verifying authenticated published bytes and reconciling the private bundles release metadata, then refreshing production registry data. Those actions require credentials, another repository, and production/release changes outside this task. No checksum was guessed or rebuilt; no release or production changes were made. See
.github/docs/d-1483-investigation.mdon main.Validation
From
free/ci:go test -mod=vendor ./internal/adhoc -run TestDashPrefixedSecretValuesAreRedacted -count=1: failed against unchanged source, passed after the fix.go build -mod=vendor ./...: passed.go vet -mod=vendor ./...: passed.go test -mod=vendor ./...: passed for the entire 150-package module.From the repository root:
python3 -B -m unittest discover -s scripts/ci/tests -p 'test_verify_registry_downloads.py': all 12 tests passed.git diff --check: passed.Public registry/catalog metadata was checked read-only, without credentials or licensed downloads.