Repository navigation
Conversation
…7-CACHE-21) Coordinator pushes the lease's planned restore blobs as digest and chunk frames; the node session routes them to the cache Before hook, which answers offset, re-hashes and publishes a read-through copy. Held copies cost no chunk frames, a corrupt copy or a flipped byte is discarded and sent again, a failed fetch degrades to a cold miss. Refusals are audited. Carrier B (agent pull) is not covered: agentapi cannot yet carry the frames and is outside this ticket's write scope.
…malising, rename carrier B test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARTIAL: carrier A (ssh) done; carrier B (agent pull) NOT done because internal/coordinator/agentapi is outside write_scope. Ticket P7-CACHE-21 stays open.
P7-CACHE-21, hand-finished after the automated worker escalated.
Delivered (carrier A, ssh stdio):
NOT delivered: carrier B (agent pull). internal/coordinator/agentapi rejects upstream
offsetframes and has no way to push digest/chunk on the control stream; both edits are outside write_scope. The node session offers no feed on carrier B, so it degrades to a cold miss with no wait. TestRemoteCacheRestoreAgent pins that degrade path only; it does not prove restore on B. Needs a follow-up with agentapi in scope.Verify: remote/session/transport race tests pass; the three TestRemoteCacheRestore* integration tests pass via go-test-ran.py; architecture, TestCodeRegistry, parity-with-core (47 cases) pass; no forbidden addresses in the diff. internal/run had one load-flaky failure (TestStatusNotPostedForPartialCancelledOrOutsideConfig) that passes alone. Reviews (adversarial, security) not run.