fstree: add compressed object decompression tool - #4079
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 9, 2026 13:35
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
==========================================
+ Coverage 26.28% 26.82% +0.53%
==========================================
Files 671 675 +4
Lines 45862 45941 +79
==========================================
+ Hits 12056 12322 +266
+ Misses 32674 32453 -221
- Partials 1132 1166 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carpawell
reviewed
Jul 10, 2026
| // The method preserves combined physical files by rewriting all hard links to | ||
| // the same new combined file. The storage node must not write to this FSTree | ||
| // while the migration is running. | ||
| func (t *FSTree) RewriteCompressed() (RewriteCompressedStats, error) { |
Member
There was a problem hiding this comment.
if it is an FSTree method, why do we need this utility then? it can be a background routing for the next release
Member
There was a problem hiding this comment.
Theoretically, yes, I also had this thought, but:
- either it needs to be synchronized with other activities (deletion first of all to avoid object resurrection) which requires some effort
- or it keeps the same logic as an outsider, but then having a separate process is easier, can be controlled by shard and can even be performed before the release
Add fstree-decompress for rewriting old zstd-compressed FSTree objects as plain canonical object bytes. Support single FSTree roots via `--path` and node configs via `--config`. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.