Skip to content

fix(dev_tools): prevent nil data error on app termination #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanadoman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dev_tools): prevent nil data error on app termination #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lua/flutter-tools/dev_tools.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ end
---@param data string
---@param _ Job
local function handle_start(_, data, _)
if #data <= 0 then return end
if not data or #data <= 0 then return end

local json = fn.json_decode(data)
if not json or not json.params then return end
Expand All @@ -146,6 +146,7 @@ end
---@param data string
---@param _ Job
local function handle_error(_, data, _)
if not data then return end
if not data:match("No active package devtools") then
ui.notify(utils.join({ "Sorry! devtools couldn't be opened", vim.inspect(data) }), ui.ERROR)
return
Expand Down