docs(spec,skills,adr): correct related-list docs for relatedList 'primary' (#2579 follow-up)#2600
Merged
Merged
Conversation
…mary' (#2579 follow-up) - field.zod.ts: fix the `relatedList` JSDoc + describe — non-primary lists stack under a single shared "Related" tab; only 'primary' earns its own tab. Drops the stale "count-aware" wording that never shipped (we chose rule Z). - skills/objectstack-ui: the single "Related" tab is no longer the ONLY layout — document `relatedList: 'primary'` as the zero-page way to promote a child table to its own tab; columns auto-derive from highlightFields. - skills/objectstack-data: add the 'primary' tri-state; note columns are optional (derive from highlightFields), ONE related list PER FK (not one per child), and self-referential hierarchies. - docs/adr/0035: update the read-side-mirror section for the tri-state, optional columns, and one-per-FK derivation. Docs/description only; no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 94 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Doc follow-up to #2594 (issue #2579) — corrects the related-list documentation to match the shipped
relatedList: 'primary'behavior.packages/spec/src/data/field.zod.ts— therelatedListJSDoc +.describe()said "count-aware: few children → a tab each, many → collapse", but we shipped rule Z: non-primary related lists stack under one shared Related tab, and only'primary'earns its own tab (no count-based auto-split). Corrected. Description-only, no behavior change → patch changeset.skills/objectstack-ui/SKILL.md— removed the now-false "a single Related tab is the only built-in layout / assign a custom Page to get tabs" claim; documentsrelatedList: 'primary'as the zero-page way to promote a child table to its own tab; notes columns auto-derive fromhighlightFields.skills/objectstack-data/rules/relationships.md— adds the'primary'tri-state; fixes "each child yields at most one related list (first eligible FK wins)" → one related list per FK (multi-FK children); notesrelatedListColumnsis optional (auto-derives fromhighlightFields) and self-referential hierarchies surface a "children" list.docs/adr/0035-config-driven-master-detail.md— read-side-mirror section updated for the tri-state, optional columns, and one-per-FK derivation.Not included (intentional)
fewer-adrs), the prominence-vs-layout rationale lives in ADR-0035 + the skills + the feat(spec): detail-page related-list tabs via relatedList: 'primary' (#2579) #2594 changeset.packages/spec/json-schema/*is untracked and rebuilds from source at publish;api-surface.jsontracks exported signatures (an additive union / optional field is invisible to it —check:api-surfacealready confirmed unchanged).Refs #2579.
🤖 Generated with Claude Code