fix(metadata-protocol): user-facing copy for writable_package_required rejection#2625
Merged
Merged
Conversation
…d rejection The rejection message is surfaced verbatim as a Studio toast, but its copy was written for developers — it cited an internal ADR path as the remedy. Rewrite the sentence as end-user remediation (switch to a writable package in the package selector, or create one); the ADR pointer moves to a docs property on the error. code/status/packageId are unchanged, so API consumers and the ADR-0070 golden regression are unaffected. Found by the Studio package-create UX dogfood (#2609, tracking #2615). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
13 tasks
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
…s interim rewrite
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 1 changed package(s). ✅ |
Contributor
Author
|
Superseded by #2618 ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rewrites the
writable_package_requiredrejection message inpackages/metadata-protocol/src/protocol.tsas end-user remediation. The message is surfaced verbatim as a Studio toast, but its copy was developer-facing — it told the user to "See docs/adr/0070-package-first-authoring.md", an internal ADR path that means nothing to a console user.docsproperty on the thrown error, so API consumers/agents keep the reference without it leaking into UI toasts.code(writable_package_required),status(422), andpackageIdare unchanged.Why
Found by the Studio package-create UX dogfood (#2609): this is the P1 "read-only rejection copy cites an internal ADR path" item, the only framework-side entry in tracking issue #2615.
Verification
turbo run build --filter=@objectstack/metadata-protocol...— cleanpackages/objectql/src/protocol-save-meta-repo-path.test.ts— 13/13 pass (assertscode/status, not copy)packages/dogfood/test/package-first-authoring.dogfood.test.ts(ADR-0070 golden regression) — 5/5 pass@objectstack/metadata-protocol: patch)Closes the framework-side checkbox in #2615.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
Generated by Claude Code