feat(studio): review-then-publish confirmation + field-level detail in the changes panel by os-zhuang · Pull Request #2271 · objectstack-ai/objectui

os-zhuang · 2026-07-05T07:33:38Z

Summary

Completes the remaining two P1 findings from the Studio "create a package and build in it" browser dogfood (objectstack-ai/framework#2615, mirrored here as #2258). The first two P1 items landed in #2263.

One-click Publish had no confirmation. The Studio header's Publish button released every package draft atomically on a single click. It now opens the pending-changes panel, and DraftChangesPanel gains an opt-in confirm footer (an "all N drafts publish atomically" note + a "Publish all" button) rendered only when the caller passes onPublish. Publishing itself stays with the caller (doPublish, unchanged); the preview-bar usage that doesn't pass onPublish keeps its read-only review behavior.
The changes panel had no detail — only name · New/Update. Each entry now expands (chevron toggle) into a lazily-fetched diff of published vs draft: field-level + added / ~ changed (which keys) / − removed rows, reusing the designer's existing diffFields, plus an "Also changed:" strip for non-fields top-level keys. A NEW item's 404 on the published read is treated as data (everything added), not an error.

New panel strings (detailLoading, detailLoadFailed, detailNone, detailChangedKeys, confirmNote, publishConfirm) are translated in all 10 locales.

Test plan

New DraftChangesPanel.test.tsx — 8 tests: pure computeChangeDetail cases (NEW item, update with added/changed/removed fields, field-less types, no-diff), footer absent without onPublish, confirm click forwards to onPublish, button disabled while publishing, and expand → lazily-fetched field diff renders.
npx vitest run packages/app-shell — 129 files / 974 tests passing.
npx vitest run packages/i18n — 93 tests passing (locale files still compile and load).
npx tsc --noEmit on app-shell and i18n — no errors in touched files.
npx eslint on the changed panel files — 0 errors (only the codebase's pre-existing fetch-in-effect warning pattern).

🤖 Generated with Claude Code

Generated by Claude Code

…n the changes panel Two P1 findings from the Studio package-create UX dogfood (objectstack-ai/framework#2615, mirrored as #2258): - One-click Publish had no confirmation: the header button released every package draft atomically straight away. It now opens the pending-changes panel, which gains a confirm footer (count note + "Publish all") when the caller passes onPublish — review-then-publish in one surface. The publish action itself stays with the caller; the preview-bar usage without onPublish keeps its read-only behavior. - The changes panel listed only "name · New/Update" with no drill-in. Each entry now expands into a lazily-fetched diff of published vs draft: field-level added/changed/removed rows (reusing the designer's diffFields) plus a changed-top-level-keys strip for everything else. New panel strings translated in all 10 locales.

vercel · 2026-07-05T07:33:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 5, 2026 7:33am

github-actions · 2026-07-05T07:37:50Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	59.5 KB	350 KB
Entry file	`index-IRIw3O_P.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.51KB	2.72KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	18.34KB	3.80KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	9.55KB	3.36KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	26.07KB	6.30KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.29KB	0.82KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	437.19KB	93.97KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	109.66KB	27.05KB
fields (index.js)	185.40KB	45.26KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.92KB	10.17KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.10KB	12.33KB
plugin-charts (index.js)	46.18KB	13.02KB
plugin-chatbot (index.js)	173.06KB	41.28KB
plugin-dashboard (index.js)	108.28KB	26.86KB
plugin-designer (index.js)	213.56KB	42.96KB
plugin-detail (index.js)	203.63KB	49.07KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	102.48KB	24.90KB
plugin-gantt (index.js)	136.67KB	33.88KB
plugin-grid (index.js)	165.48KB	43.77KB
plugin-kanban (index.js)	48.15KB	12.94KB
plugin-list (index.js)	97.89KB	23.09KB
plugin-map (index.js)	16.78KB	5.23KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.78KB	20.89KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…8n sweep Upstream landed read-only gating + live API-name sync (#2263) and review-then-publish + changes detail (#2271) in parallel — take those implementations wholesale (they supersede this branch's #2259/#2260/#2261 work, including per-keystroke name sync and a structured diffFields-based detail). Kept from this branch: create-app nav scaffolding (#2262), the studio-design i18n sweep (#2264), ObjectFormDesigner's full read-only mode, and the nav-seeded skeleton conformance case; dropped the now- redundant blur-based derive tests in favour of upstream's. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt

…name derive and changes-panel implementation, keep this PR's four-pillar readOnly gating, nav scaffold and i18n sweep

github-actions Bot added the tests label Jul 5, 2026

os-zhuang marked this pull request as ready for review July 5, 2026 07:48

os-zhuang merged commit 7283d18 into main Jul 5, 2026
10 checks passed

os-zhuang deleted the work/2615-p1-publish-confirm branch July 5, 2026 07:48

os-zhuang pushed a commit that referenced this pull request Jul 5, 2026

Merge origin/main — reconcile with #2263/#2271: keep main's live API-…

12fbbee

…name derive and changes-panel implementation, keep this PR's four-pillar readOnly gating, nav scaffold and i18n sweep

os-zhuang mentioned this pull request Jul 5, 2026

feat(studio): package-id wizard feedback + P3 dogfood polish #2275

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(studio): review-then-publish confirmation + field-level detail in the changes panel#2271

feat(studio): review-then-publish confirmation + field-level detail in the changes panel#2271
os-zhuang merged 1 commit into
mainfrom
work/2615-p1-publish-confirm

os-zhuang commented Jul 5, 2026

Uh oh!

vercel Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 5, 2026

Summary

Test plan

Uh oh!

vercel Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants