feat(studio): edit a package's manifest from the detail sheet#2303
Merged
Conversation
Follow-up to the package management work (#2297): the standard PackageDetailSheet now has an "Edit" action opening a standard dialog to change a package's name / description / version, wired to the new framework endpoint `PATCH /api/v1/packages/:id`. `id` / `scope` / `type` stay immutable (not shown as inputs). - `EditPackageDialog` — standard Dialog, prefilled from the manifest, semantic-version validation, inline error; PATCHes and returns the updated package. - Studio switcher: the manage sheet's snapshot now refreshes after any lifecycle action (shared `fetchFullPackage`), so an edit shows immediately instead of a stale view; delete-of-current still navigates away. - i18n: en + zh for the edit dialog. - Integration test drives the real dialog: prefill → PATCH (asserts URL / method / body) → server response → close; version-validation gate; server-error path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DxVTSDSXrdnfqHNBkHB6yi
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged package-management work (#2297): closes the "edit package" gap. Previously a package's
name/description/versioncould never be changed after creation because there was no backend endpoint.Pairs with objectstack-ai/framework#2646 (adds
PATCH /api/v1/packages/:id).Changes
EditPackageDialog— a standardDialog(same shape asCreatePackageDialog), prefilled from the manifest, with semantic-version validation and an inline error. On save itPATCHes/api/v1/packages/:idand returns the updated package.id/scope/typeare immutable and not shown as inputs.PackageDetailSheet— new Edit action (first button in the actions row) opening the dialog; on success it shows "Package updated" and refreshes.fetchFullPackage), so an edit shows immediately instead of a stale view; delete-of-current still navigates away.Verification
EditPackageDialog.test.tsx) drives the real dialog in a DOM: prefill → save → asserts thePATCHURL / method / body → server response applied → dialog closes; plus the version-validation gate (save disabled, no request) and the server-error path (message shown, stays open).tsc --noEmiton@object-ui/app-shell: 0 errors;eslinton changed files: 0 errors.🤖 Generated with Claude Code
https://claude.ai/code/session_01DxVTSDSXrdnfqHNBkHB6yi
Generated by Claude Code