fix: populate Obot groups for token auth - #7949
Merged
Merged
Conversation
This allows group-based profiles with Obot groups to work. Signed-off-by: Donnie Adams <donnie@obot.ai>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The central effective-role behavior lacks a regression test covering MCP-scoped tokens.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables group-based profiles for persistent token authentication and configures composite MCP logging.
Changes:
- Resolves effective Obot roles for all numeric token users.
- Supplies the default logger to
mmmcp.
File summaries
| File | Description |
|---|---|
pkg/jwt/persistent/persistent.go |
Populates effective Obot role groups for scoped tokens. |
pkg/api/handlers/mcpgateway/handler.go |
Configures composite gateway logging. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
njhale
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows group-based profiles with Obot groups to work.