Repository navigation
fix(verify): distinguish appended exchanges from archive refreshes - #177
Open
HengYangDS wants to merge 4 commits into
Open
HengYangDS wants to merge 4 commits into
HengYangDS wants to merge 4 commits into
Conversation
HengYangDS
marked this pull request as ready for review
September 26, 2026 05:10
Author
|
Author follow-up for #177: the exact PR head is still mergeable, but its CI run remains action_required and has not executed. The consolidated current request on #180 covers this contribution as well: please approve the fork workflow and review its narrow source behavior for merge. I will address resulting failures and keep generated output, portability and generality qualified; no hosted pass or installation update is claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--verifytreats archive mtime changes as an outdated index even when every exchange is indexed. Missing summaries can hide unindexed archives, and broad--repaircan regenerate embeddings and summaries unnecessarily.Change
lineEndwith the indexed high-water mark; distinguish appended content, unindexed archives, missing summaries and mtime-only refreshes.archiveRefreshesis diagnostic, not a repair target. An unindexed status alone does not select a repair. Historical backfill remains outside this change. The direct repair test obtains its issue shape from the native verifier, avoiding a fixed field inventory.Verification
Exact head:
c8c190007661c50bafbb6753228658b6031b56e4; current target:7e06519357777badd7a115d2014a7ef845904310.Fresh qualification on 2026-10-10, macOS arm64, Node 22.23.3/npm 10.9.9:
npm cisucceeds with this PR's unchanged manifest. Its native postinstall verifies the SQLite stack; dependencies are not borrowed from another PR.npm run buildand original bundled-script syntax pass. The fullnpm testpasses 356/356 across 63 files, zero skips, with every tracked input—including the original committed bundle—matching this exact head.initEmbeddings()and replaying the unchanged suite passes; no timeout or gate was loosened. Cold model preparation is therefore not claimed to fit those hooks.f4ac20b63ee3980db1711ee636f8b79b56fdd6664e5c6cd50809d85722af9398; it is qualification evidence, not a repository lockfile change.The declared Vitest 3 range has known dev-tool advisories (GHSA-82fw-gwwq-j7x9, GHSA-5gmw-xhrv-c9v3, GHSA-85c8-ppgw-ccpr). The operator accepted only trusted, isolated one-shot tests without credentials or a test server. Source dependencies and the live installation are unchanged; this is not security clearance for arbitrary input.
The earlier borrowed-tree Node matrix is not exact-input qualification. Current Node 24, hosted Linux/Windows, coverage and live-consumer acceptance are not verified. Exact-head CI remains
action_requiredawaiting maintainer approval.Integration
The unrelated committed MCP dependency drift is now removed: verifier and index-CLI modules are not reachable from MCP, so its bundle is byte-exact to the upstream base. No host-specific paths, policies or dependency upgrade are added. If #109 or #180 lands first, refresh shared verifier changes and rerun invalidated checks before merge. Maintainer merge and release remain separate outcomes.
Minimal-scope revision (2026-10-11)
Current exact head:
ab29746447333ab3755a961713b75e454386556e; parent:c8c190007661c50bafbb6753228658b6031b56e4. The qualification above is historical evidence for that parent, not an exact-head claim for this follow-up.dist/mcp-server.jsto the unchanged upstream7e06519357777badd7a115d2014a7ef845904310blob. All ten bundled product-source sections already matched upstream; original esbuild reachability excludessrc/verify.tsandsrc/index-cli.ts. This removes unrelated dependency behavior/layout changes.npm run build, bundle syntax and 356/356 tests across 63 files, zero skips, including three actual packaged MCP tests, pass on existing workspace Node 24.19.0/npm 12.2.0, macOS arm64. The original MCP bundle is retained after the build; fresh resolver bytes are not claimed to reproduce an original official build.npm cidependency tree qualified for fix(indexer): keep session indexing incremental on append #176; the three PRs have identical manifests and the prior resolver lock is unchanged. This is not a separate install, an official committed lock, a cold-model claim or hosted/Windows acceptance. The model cache is byte-qualified, nativeallowScriptsand trusted-isolated-test risk limits stay unchanged, and owned test temporary state is removed with exact absence readback.Current Node 24 local source/packaged acceptance is now proved; hosted CI/workflow approval, Windows, coverage, maintainer merge, stable release inclusion and installed-consumer adoption remain separate unverified gates. No duplicate approval ping accompanies this factual revision.