Repository navigation
fix: inspect native Codex plugin and hook materialization in Doctor - #184
Open
HengYangDS wants to merge 1 commit into
Open
HengYangDS wants to merge 1 commit into
HengYangDS wants to merge 1 commit into
Conversation
Author
|
Author follow-up on exact head e2b3387: the previously disclosed declared-toolchain evidence gap is now resolved. The original two focused test files pass 14/14 under the repository-declared Vitest 3.2.7, and TypeScript 5.9.3 --noEmit passes. Source and committed manifests/locks are unchanged; no live plugin installation, credential, model or policy update was made. Native install warnings are retained, including the pre-existing allow-scripts configuration warning and prebuild-install deprecation. This is local acceptance, not hosted CI: exact-head Actions still require maintainer approval before execution. Please approve and run the waiting checks, then review the narrow native Doctor behavior for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Codex Doctor inspect native plugin materialization and hook configuration instead of obsolete feature flags and explicit-MCP assumptions. Plugin-provided servers need not appear in
codex mcp list. Failed native inspection is unknown, not absence; a deliberately disabled hook must not trigger advice to override policy.This is one generic Doctor change, not the larger local indexing/admission stack. Integration base:
7e06519357777badd7a115d2014a7ef845904310. Head:e2b33875433d5f8eac335de06a06a6fde33f851d.Validation
node node_modules/vitest/vitest.mjs run test/codex-doctor.test.ts test/doctor-observations.test.ts --reporter=dot: 14/14 pass under declared Vitest 3.2.7. The earlier Vitest 5 result is not used as declared-toolchain compatibility evidence.node node_modules/typescript/bin/tsc --noEmit: passes with TypeScript 5.9.3.git diff --check: passes. Source, manifests and committed lockfiles are unchanged by toolchain qualification.allowScriptsownership and deprecatedprebuild-installare retained, not suppressed.Hosted fork CI still requires maintainer approval and has not executed. A native CLI/model tool loop on this rebased branch was not run. Configuration diagnostics do not establish model/storage health or all-consumer acceptance.