Add truthful MCP tool contracts - #5
Open
epistemedeus wants to merge 1 commit into
Open
Conversation
👷 Deploy request for agentterminal pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A credential-free audit of the live MCP endpoint found that all six tools had descriptions and input schemas, but none had titles or output schemas. Reading the source also exposed one description/runtime drift:
get_merchantsaid Tier 2 required a credential, while the implementation and tests intentionally give anonymous and credentialed callers the same read access.This keeps the repair narrow:
registerToolAPI;structuredContentonly for the three compact deterministic results:list_categories,list_rails, andwhoami;get_merchantcredential description.The SDK validates successful structured results against the declared schemas. The in-memory MCP tests also prove that exactly the intended three tools advertise output schemas and that
whoamireturns identical text and structured content.Validation
pnpm -r lintpnpm -r typecheckpnpm -r test(114 tests across core and MCP)pnpm validate-datapnpm -r buildAll pass from a clean dependency install using the repository-pinned pnpm 11.1.2.
This changes no merchant data, read access, rate limits, transport, payment verification, or live probe behavior.