check.html: rc.22 publishes v3, so the #120 scope lines are corrected and the parity check holds v3 to the package - #124
Merged
Conversation
…nd the parity check holds v3 to the package rc.22 published the v3 refusal construction (REFUSAL_PAYLOAD_TYPE_V3, and signableFromRefusalRow for the served shape) and npm's `latest` now serves it. The scope lines added by #120 said the v3 construction was in no published release and did not check with `npm install`; that held through 24 August 2026 and the publish makes it false. Corrected in place, dated. Measured against a clean install of @observer-protocol/policy-engine@1.0.0-rc.22 from the registry: all v3 records verify rather than throw, the served shape reads through signableFromRefusalRow, and v1/v2 are unchanged. Pin bumped rc.21 -> rc.22; the eight data-engine-version markers and the engine-payload-exports:npmLatest figure moved with it (the "no longer inside that band" sentence survives at rc.22). check-page-payload-parity now holds the served rows and the five v3 vectors byte-identical to the published package, the same way v1 and v2 store records already were; the five fixtures are demoted to regression vectors against the enforcement point's own signatures. The demonstration-key caveat is unchanged in substance: the publish changes what verifies, not who held the key. The one clause implying the five demo records were the only thing holding the v3 construction is corrected, because the package now holds it too.
✅ Deploy Preview for observerprotocol ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rc.22 is published (registry direct:
dist-tags.latestand.rcboth1.0.0-rc.22, gitHead75f0d50). #120's v3 scope lines said the v3 construction was in no published release and did not check withnpm install. That was true when written and the publish makes it false.Measured, not reasoned. Against a clean
npm install @observer-protocol/policy-engine@1.0.0-rc.22 --install-linksfrom the registry, all v3 records verify rather than throw, the served shape reads throughsignableFromRefusalRow, the tampered row is rejected, and v1/v2 are byte-unchanged.What changed
npm install; the version paragraph now says v1, v2 and v3 are the package's.1.0.0-rc.21 → 1.0.0-rc.22(scripts/package.json+ lockfile).sync-engine-versionmoved the eightdata-engine-version="current"markers with it, and theengine-payload-exports:npmLatestmeasured figure moved to rc.22 (the "no longer inside that band" sentence survives — confirmed bysentences-at-risk, not by argument).scripts/check-page-payload-parity.mjs— repointed. The served rows and the five v3 vectors are now held byte-identical to the published package (19/19), the same way v1/v2 store records already were; the five fixtures are demoted to regression vectors against the enforcement point's own signatures. Stale "no package to hold them to / 6f58fcb" comments removed.Checks (run under rc.22)
Green:
check-page-payload-parity(19/19 held to package),check-measured-figures,sync-engine-version --check,check-public-checker,check-page-attestation-parity,check-declarations,check-outbound-links,check-section05-transcript,verify-published-credentials.Out of scope, flagged not fixed
verify.html §"the same engine, two releases behind" (hosted
engine.runningrc.10 vs published rc.22) is a stale version-gap number. It predates this change (already inaccurate at rc.21) and is unrelated to v3 refusals, so it is left for a separate correction.Not self-merged — this ships to observerprotocol.org on merge to master.