Repository navigation
Omit tests of Weak.get_copy - #586
Merged
Merged
Conversation
Collaborator
Author
|
This gets the test suite green again on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
trunk(5.7) and the new5.6branch ocaml/ocaml#15064Weak.get_copyis now considered dangerous, triggers a deprecation error, and instead just callsWeak.get.With that in mind, there seems little point in continuing to hammer it in PBTs, so this PR omits the function from the
LinandSTMtests ofWeak.