Repository navigation
Conversation
Restore per-file tracking from ec4d25b, the earlier version of ocaml#16507, and apply it to the full lock-package dependency closure. Document that this works around the engine bug with overlapping directory dependencies. Update the binary and library-closure expectations. Leave cookie-load deduplication for a follow-up and record the current per-rule loads. Fixes ocaml#16547 Signed-off-by: Ali Caglayan <alizter@gmail.com>
Collaborator
Author
|
Will aim this directly at 3.25 |
Member
|
Reopening, as I'd like to ensure that this gets into the trunk and that we cherry pick it from there. I'll bring the discussion to zulip! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use per-file package dependencies to work around the sandbox overlap bug exposed by #16507, without engine changes.
Fixes #16547.