Skip to content

fix(sandbox): share directory traversal across sandbox modes - #16675

Draft
Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:push-rrwvvoxnnnuk
Draft

Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:push-rrwvvoxnnnuk

Conversation

@Alizter

@Alizter Alizter commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Share directory traversal across sandbox modes and apply the selected mode only to files.

Builds on #16634. Records the symlink-mode directory-copy regression to demonstrate why the follow-up copy-action fix is needed.

Exercise a directory copy action with a generated directory dependency,
without Melange or package management. Record the current behavior in
symlink, copy, and hardlink sandbox modes before changing input traversal.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Create real directories for copy, symlink, and hardlink sandbox inputs.
Use Tree_copy for traversal and apply the selected mode only to files.

Keep patch-back directory handling and overlap deduplication unchanged.
Copy mode continues to reject overlapping files.

Record the regression in directory copy actions under symlink sandboxing.
This demonstrates why copying sandbox-generated file links needs a
separate fix.

Signed-off-by: Ali Caglayan <alizter@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant