Skip to content

Move the FMI package into its own file FMI.sysml - #14

Merged
jbussemaker merged 2 commits into
mainfrom
fmi-package-file
Oct 14, 2026
Merged

jbussemaker merged 2 commits into
mainfrom
fmi-package-file

Conversation

@LyasAll

@LyasAll LyasAll commented Oct 8, 2026

Copy link
Copy Markdown
  • Moved the FMI package out of ModelBasedDesign.sysml and into its own FMI.sysml file
  • Updated some documentation strings and metadata

jbussemaker
jbussemaker previously approved these changes Oct 10, 2026
@jbussemaker

Copy link
Copy Markdown
Collaborator

Thanks Elias, the contribution is ready to merge in principle!

The checks are failing because in the MBD package, the maximize and minimize functions are used to extract scalar values from a time domain result. This however leads to failing package checks due to a missing fn parameter.

That's because maximize is an optimization function. In this case, rather the DataFunctions::max (and min) functions should be used.

Even though this is unrelated to your pull request, can you fix it in this PR so we don't need a separate one?

@LyasAll

LyasAll commented Oct 14, 2026

Copy link
Copy Markdown
Author

Hi Jasper,
I fixed what you pointed out I think and committed it. Ready for your approval :)

@jbussemaker jbussemaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jbussemaker
jbussemaker merged commit 517c7c5 into main Oct 14, 2026
2 checks passed
@jbussemaker
jbussemaker deleted the fmi-package-file branch October 14, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants