Repository navigation
test(ui): trim the Playwright suite to one test per flow - #130
Merged
Merged
Conversation
Page tests run in Chromium only, since they check the page's logic and the flows against the test server cover WebKit. Editor page tests are merged into one test per flow, with each step checked in it, and the ones that measured sizes, positions, colors or labels are removed, since the visual baselines and the accessibility scan cover how the page looks. Server editor tests keep what only the real files and engine can show, and leave the rest to the page tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
odevine
changed the title
The test assumed the editor's preview is drawn at 300 dpi and worked out the full size from the preview's width. The preview resolution is a setting, and applying a preset stores it capped to the active template, which the fixtures do not put back. After the overrides tests, the WebKit run drew the preview at 274 dpi and the expected width was 95 pixels off. The test now reads the canvas from the template's layout file and expects the saved PNG to be exactly that size, and larger than the preview, whatever the preview resolution is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nder The accessibility scan waited for every animation on the page, and the activity spinner of a render that is never answered runs forever, so on a slow runner the editor-levers scene timed out. The scan now waits only for animations that end. The test that opens another template answered one render by its number, and opening it can start another, so it now answers the newest render until the template's layers are listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The launch check read the lever's new value back from the file and then pressed Undo, but the page records the edit only when its own reply to the save arrives. On a slow runner the read could come first, so Undo was still disabled and the click did nothing. Either the check timed out, or it passed on the field briefly showing the old value with nothing undone. It now waits for Undo to be enabled, then for the old value to be back in the file and in the field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page tests run in Chromium only, since they check the page's logic and
the flows against the test server cover WebKit. Editor page tests are
merged into one test per flow, with each step checked in it, and the
ones that measured sizes, positions, colors or labels are removed, since
the visual baselines and the accessibility scan cover how the page
looks. Server editor tests keep what only the real files and engine can
show, and leave the rest to the page tests.