[IMP] construction_developer: add routes configuration by trcazier · Pull Request #13 · odoo-dev/industry

trcazier · 2026-06-16T10:19:48Z

This commit sets up the picking types, routes, and rules to setup the automatic MO/deliveries to use the standard stock capabilities for the reworked work items.

task-6292786

move features from data into new feature subdir remove duplicate view split work_items into new feature files

This commit sets up the picking types, routes, and rules to setup the automatic MO/deliveries to use the standard stock capabilities for the reworked work items. task-6292786

…demo & move default into noupdate + fix form view fields location

…n automatization

Introduced fields to access the BOM instead of relying on brittle references

…tead

…te, locations

vava-odoo

first light review 👍

vava-odoo · 2026-06-26T07:50:21Z

+    if bom.x_original_sol_id:
+        bom.x_original_sol_id.write({'price_unit': bom.x_unit_price, 'purchase_price': bom.x_unit_cost})


the condition is in the view + write would just void if there is no x_original_sol_id

Suggested change

if bom.x_original_sol_id:

bom.x_original_sol_id.write({'price_unit': bom.x_unit_price, 'purchase_price': bom.x_unit_cost})

bom.x_original_sol_id.write({'price_unit': bom.x_unit_price, 'purchase_price': bom.x_unit_cost})

vava-odoo · 2026-06-26T08:08:08Z

+        <field name="store" eval="False"/>
+        <field name="depends">x_unit_price,x_original_sol_id,x_original_sol_id.price_unit</field>
+        <field name="compute"><![CDATA[
+for bom in self: bom['x_price_different_from_so'] = round(bom.x_unit_price, 2) != round(bom.x_original_sol_id.price_unit, 2)


isn't float_compare available here?

vava-odoo · 2026-06-26T08:16:47Z

+        <field name="readonly" eval="True"/>
+        <field name="depends">order_line,order_line.x_bom_id</field>
+        <field name="compute"><![CDATA[
+for so in self: so['x_any_sol_bom'] = bool(so.order_line.x_bom_id)


probably faster

Suggested change

for so in self: so['x_any_sol_bom'] = bool(so.order_line.x_bom_id)

for so in self: so['x_any_sol_bom'] = any(line.x_bom_id for line in so.order_line)

vava-odoo · 2026-06-26T08:19:04Z

                />
            </xpath>
+            <xpath expr="//field[@name='order_line']/list//field[@name='route_ids']" position="after">
+                <field name="x_product_bom_template_id" column_invisible="True"/>


I thought required fields for invisibility/required/... conditions were automatically added to the view since 18.0

Suggested change

<field name="x_product_bom_template_id" column_invisible="True"/>

vava-odoo · 2026-06-26T08:19:49Z

+        <field name="ttype">many2one</field>
+        <field name="relation">mrp.bom</field>
+        <field name="related">product_id.product_tmpl_id.x_bom_template_id</field>
+        <field name="name">x_product_bom_template_id</field>


store False? Or used elsewhere?

vava-odoo · 2026-06-26T09:32:17Z

+        <field name="compute"><![CDATA[
+for sol in self:
+    if not sol.x_bom_id and sol.product_template_id.bom_ids and sol.product_template_id.route_ids: 
+        sol['x_bom_id'] = sol.product_template_id.bom_ids.filtered(lambda b: b.x_is_template)[0].id


I don't remember why route_ids is here, but it's not a new code so 🙈

Suggested change

sol['x_bom_id'] = sol.product_template_id.bom_ids.filtered(lambda b: b.x_is_template)[0].id

sol['x_bom_id'] = sol.product_template_id.bom_ids.filtered('x_is_template')[0].id

vava-odoo · 2026-06-26T09:40:59Z

+        code = f"{so.name} - {so.partner_id.name}" + f" - {bom.code}" * bool(bom.code)
+
+        custom_bom = bom.copy({'code': code, 'x_original_sol_id': sol.id, 'x_parent_bom_id': bom.id}).id
+        sol['x_bom_id'] = custom_bom


this part is duplicated elsewhere, not sure if it is an issue or we should make it a server action on it's own

like in the other you put a .id at the end 😇
but bigger divergences could occur

vava-odoo · 2026-06-26T09:43:53Z

+        <field name="update_path">location_id</field>
+        <field name="update_field_id" ref="stock.field_stock_picking__location_id"/>
+        <field name="evaluation_type">equation</field>
+        <field name="value"><![CDATA[record.sale_id.partner_shipping_id.x_ws_location_id.id if record.sale_id else False]]></field>


sale_id is False in the filter_domain... Do you need to remove it if sale_id is removed?

vava-odoo · 2026-06-26T09:52:15Z

+        <field name="value"><![CDATA[[(6, 0, [
+            record.env.ref('purchase_stock.route_warehouse0_buy').id,
+            record.env.ref('construction_developer.stock_route_warehouse_on_site_delivery').id,
+            record.env.ref('construction_developer.stock_route_on_site_consumption_goods').id,
+        ])]]]></field>


why those ones. I don't get this automation n°2

vava-odoo · 2026-06-26T09:58:20Z

+                obj().env.ref('construction_developer.stock_route_warehouse_on_site_delivery').id,
+                obj().env.ref('purchase_stock.route_warehouse0_buy').id


why not coming back to those ones in the automations then? 🤔

trcazier force-pushed the master-construction-wi-bom-routes-trcaz branch from a3ff425 to bdf8f01 Compare June 16, 2026 13:37

trcazier changed the title ~~[IMP] construction_developer: improve routes & locations~~ [IMP] construction_developer: add routes configuration Jun 16, 2026

trcazier force-pushed the master-construction-wi-bom-routes-trcaz branch 2 times, most recently from 2ee0afc to cee5df6 Compare June 17, 2026 07:38

[IMP] construction_developer: original PR fixup

941bb7c

move features from data into new feature subdir remove duplicate view split work_items into new feature files

trcazier force-pushed the master-construction-wi-bom-routes-trcaz branch from cee5df6 to f069b16 Compare June 17, 2026 08:00

trcazier added 9 commits June 18, 2026 12:25

[IMP] construction_developer: 2: add routes configuration

27f8d86

This commit sets up the picking types, routes, and rules to setup the automatic MO/deliveries to use the standard stock capabilities for the reworked work items. task-6292786

[IMP] tests, construction_developer: allow other structure than data/…

292df7d

…demo & move default into noupdate + fix form view fields location

[FIX] construction_developer: lpie's review 1

dd8835e

[IMP] construction_developer: 3: add BOM templates and route selectio…

f8d42c6

…n automatization

[IMP] construction_developer: add comments

526389d

[FIX] construction_developer: automation triggering on all BOM deletions

e34f45c

[REF] construction_developer: facilitate BOM lookup

86da001

Introduced fields to access the BOM instead of relying on brittle references

[IMP] construction_developer: make default SOL BOM use a template ins…

e1f5286

…tead

[IMP] construction_developer: read_group -> search

a644b2f

trcazier force-pushed the master-construction-wi-bom-routes-trcaz branch from 38f7281 to a644b2f Compare June 18, 2026 10:27

trcazier added 3 commits June 24, 2026 11:07

[IMP] construction_developer: 3 bis. add bom cost/margin/price

6b9f657

[IMP] construction_developer: 4. BoM & SOL features: wand, price upda…

8989c75

…te, locations

[IMP] construction_developer: Add features comments

f12d5c3

vava-odoo reviewed Jun 26, 2026

View reviewed changes

trcazier added 2 commits June 26, 2026 12:07

[FIX] construction_developer: traceback on sol kit

3ad56f2

[FIX] construction_developer: always duplicating bom on wand click

6e3cff5

trcazier force-pushed the master-construction-wi-bom-routes-trcaz branch from c49f573 to 6e3cff5 Compare June 26, 2026 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[IMP] construction_developer: add routes configuration#13

[IMP] construction_developer: add routes configuration#13
trcazier wants to merge 15 commits into
master-construction-wi-bom-poc-trcazfrom
master-construction-wi-bom-routes-trcaz

trcazier commented Jun 16, 2026 •

edited

Loading

Uh oh!

vava-odoo left a comment

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

vava-odoo Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if bom.x_original_sol_id:
		bom.x_original_sol_id.write({'price_unit': bom.x_unit_price, 'purchase_price': bom.x_unit_cost})

	for so in self: so['x_any_sol_bom'] = bool(so.order_line.x_bom_id)
	for so in self: so['x_any_sol_bom'] = any(line.x_bom_id for line in so.order_line)

	sol['x_bom_id'] = sol.product_template_id.bom_ids.filtered(lambda b: b.x_is_template)[0].id
	sol['x_bom_id'] = sol.product_template_id.bom_ids.filtered('x_is_template')[0].id

		obj().env.ref('construction_developer.stock_route_warehouse_on_site_delivery').id,
		obj().env.ref('purchase_stock.route_warehouse0_buy').id

Uh oh!

Conversation

trcazier commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vava-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trcazier commented Jun 16, 2026 •

edited

Loading