Skip to content

[ADD] om_aed_currency_symbol: UAE Dirham sign - #212

Merged
github-actions[bot] merged 1 commit into
odoomates:20.0from
akshaymanoj87:20.0-add-om_aed_currency_symbol
Nov 1, 2026
Merged

github-actions[bot] merged 1 commit into
odoomates:20.0from
akshaymanoj87:20.0-add-om_aed_currency_symbol

Conversation

@akshaymanoj87

Copy link
Copy Markdown
Contributor

What and why

Adds om_aed_currency_symbol for 20.0: shows the UAE Dirham sign (U+20C3) for the AED currency in the backend, PDF reports, website, portal and Point of Sale, using a small unicode-range font for devices that don't support the sign yet. It is a bridge until Odoo supports the sign natively.

This addresses the review feedback sent to the contributor by e-mail:

  • README.rst (replaces README.md) with Credits: Contributors and Author & Maintainer.
  • Font origin and license documented in the README.
  • Report CSS reduced from 161 KB to about 29 KB: the font files in static/src/fonts are referenced by URL instead of embedding the glyph about 90 times as base64.
  • Bridge note (the suggested wording) added to the manifest description, README and Store page.
  • Uninstall hook leaves the symbol untouched if Odoo's own currency data already uses U+20C3; tests added.

How to test

  1. Install om_aed_currency_symbol on a fresh database with the AED currency active: AED amounts show the Dirham sign before the amount (invoice form, list, PDF report).
  2. Uninstall the module: the symbol goes back to "AED".

Versions

Branch 20.0. Backports to 18.0 and 19.0 will follow after this is merged.

@odoomates

Copy link
Copy Markdown
Owner

Hi @akshaymanoj87, thank you, this is very good work: every point of our review is addressed, and CI is green.

One last thing, about the origin of the glyph. The README says that the glyph and the fonts were "created for this module by Odoo Mates", and the font files say "Odoo Mates. Licensed under LGPL-3". However, the Content Credentials (C2PA) embedded in static/src/fonts/om_uae_dirham.svg say it was produced with an AI assistant at your request. That is perfectly fine for us: you own what you created that way, no third-party font is involved, and the sign itself is the official one. But we would like the README and the files to say so accurately rather than attribute the glyph to us.

Could you please:

  1. README.rst, section Font origin and license: change the Creator line to something like:

    * **Creator:** the glyph outline (``om_uae_dirham.svg``) was drawn for this module by Akshay Manoj,
      with the help of an AI tool, and the fonts were built from it. It is not taken from any third-party
      font.

    and keep License: LGPL-3 and the Design line as they are.

  2. Font files (TTF, WOFF, WOFF2, regular and bold): update the copyright field the same way, for example Akshay Manoj for Odoo Mates. Licensed under LGPL-3 with the Odoo module.

Please amend your single commit so the PR stays one commit. Once that is in, the module is ready on our side; we will merge it a little later, together with the review of the rest of the batch.

Thanks again!

@akshaymanoj87
akshaymanoj87 force-pushed the 20.0-add-om_aed_currency_symbol branch from c29b246 to ffd4837 Compare November 1, 2026 09:46
@akshaymanoj87
akshaymanoj87 force-pushed the 20.0-add-om_aed_currency_symbol branch from ffd4837 to b288798 Compare November 1, 2026 09:47
@odoomates odoomates closed this Nov 1, 2026
@odoomates odoomates reopened this Nov 1, 2026
@odoomates

Copy link
Copy Markdown
Owner

/mergebot r+

@github-actions
github-actions Bot merged commit 12ef6f6 into odoomates:20.0 Nov 1, 2026
5 checks passed
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Merging now. The branch is 4 commit(s) behind 20.0.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

🎉 Merged, thank you @akshaymanoj87!

Welcome to the contributors of Odoo Apps: this is your first merged pull request here, and we hope the first of many. Kudos for [ADD] om_aed_currency_symbol: UAE Dirham sign: it is on the 20.0 branch now, and reaches the users with the next update of the module on the Odoo Apps store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants