Repository navigation
fix: README table pipes, Pages LFS staging + H.264 site videos, sample output - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes surfaced by a first-run impression of the README + live demo:
|characters (|dist(a,b) − dist(a,c)| < EPS), which CommonMark parses as column separators, collapsing the column. Escaped as\|.pages.ymlchecked out withoutlfs: true, so the deploy staged ~130-byte LFS pointer files instead of the real MP4s. Addedlfs: true.mp4v(MPEG-4 Part 2, ADR 0004) — Chrome/Firefox/Edge do not play MPEG-4 Part 2 in<video>(verified via ffprobe:codec_name=mpeg4). The deploy job now re-encodes the site copies to H.264 (ffmpeg -c:v libx264 -pix_fmt yuv420p -movflags +faststart);assets/videos/*.mp4staysmp4v— the pipeline deliverable is unchanged.row 3/row 4error lines a real run prints (those rows are deliberately invalid by design). Output block now matches an actual run.Also: site quickstart said "Python ≥ 3.10"; numpy 2.5 requires ≥ 3.12 (README already said this) — aligned.
Verification
codec_name=h264), error-free with-v error.AI disclosure
This PR was authored by an AI assistant (OpenCode agent, GLM) based on a user's issue report; all changes reviewed against ADR 0004 and the testing strategy.