fix(nip47): add fee_skim_mloki and circle_wallet fields dropped by json.Unmarshal - #21
Merged
Merged
Conversation
…on.Unmarshal
lokihub's get_info_controller.go sends a circle_hub-only `circle_wallet:
{available_mloki, max_exp_secs, fees_ppm, circle_policy}` object, and its
payResponse/Transaction both carry `fee_skim_mloki` for a circle_wallet
member's own outgoing payments -- neither had a matching field here, so
encoding/json silently dropped both on Unmarshal and every caller
(cashctl's `wallet get-info`, `decode --check`) saw them vanish.
Adds GetInfoResult.CircleWallet (new CircleWalletInfo type) and
FeeSkimMloki on Transaction/PayInvoiceResult/PayKeysendResult.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nip47.GetInfoResult/PayInvoiceResult/PayKeysendResult/Transactionhad no field to catch lokihub's circle_hub-onlycircle_walletobject or itsfee_skim_mlokipayment field —encoding/jsonsilently drops unknown wire fields on Unmarshal, so every caller (cashctl'swallet get-info,decode --check) lost this data entirely.GetInfoResult.CircleWallet(newCircleWalletInfotype) andFeeSkimMlokionTransaction/PayInvoiceResult/PayKeysendResult, with round-trip tests guarding both the populated and absent cases.Test plan
go build ./...go test ./nip47/...🤖 Generated with Claude Code