Add Procrustes scale centered function with test cases - #73
Merged
Merged
Conversation
…o procrustes_scale, but centers before rotation. Test cases added for both centered and uncentered
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Adds centered Procrustes scaling with rotation, scaling, and translation support.
Changes:
- Added
procrustes_scale_centered. - Added tests for centered and uncentered transformations.
File summaries
| File | Description |
|---|---|
tests/preprocessing/test_align.py |
Tests centering, identity, scaling, rotation, and transformation recovery. |
src/embkit/align.py |
Implements centered Procrustes scaling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added procrustes function with centering and scaling
The function procrustes_scale_centered computes the same rotation as procrustes_scale, but centers beforehand, following the standard orthogonal procrustes approach.
Changes
align.py: New procrustes_scale_centered() function, taking identical args to procrustes_scale()
test_align.py: Generated tests for the new centered procrustes and added potentially missing tests for the uncentered approach.