Align fit_vae input casting with model parameter dtype - #74
Merged
Merged
Conversation
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix potential float mismatch between training inputs and model params
Align Sep 15, 2026
fit_vae input casting with model parameter dtype
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
kellrott
marked this pull request as ready for review
September 15, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fit_vaewas force-casting training batches tofloat32, which can conflict with models initialized inbfloat16(e.g., via CLI--bfloat16). This change removes the hardcoded cast and ensures batch tensors follow the model’s parameter dtype at training time.Training path: remove hardcoded fp32 cast
fit_vae, replacex_tensor.to(device).float()with dtype-aware casting derived from model parameters.Dtype policy in
fit_vaemodel_dtypeonce after moving model to device.device + model_dtypedeviceonlyRegression coverage
float32loader batches are converted tobfloat16when the model parameters arebfloat16.