Fix missing import in legacy model loading - #77
Merged
Merged
Conversation
Contributor
Author
|
The legacy models aren't covered by tests, which is likely how this slipped through. Since the older model format is being replaced, I'm thinking of leaving test coverage as-is. Happy to add tests if it's worthwhile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing Layer import.
Loading legacy models uses build_layer_list(), which requires Layer to be imported (new models bypass this and never touch Layer). Layer is missing and NameError is thrown whenever legacy is loaded.
Should just need to add Layer import to fix.
Fixes #76