Skip to content

feat: add desktop notifications - #191

Merged
olalie merged 6 commits into
mainfrom
feat/desktop-notifications
Sep 16, 2026
Merged

olalie merged 6 commits into
mainfrom
feat/desktop-notifications

Conversation

@olalie

@olalie olalie commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

Add desktop notifications for Significant Connections on Windows, Linux, and macOS.

Desktop notifications are enabled by default and can be controlled with Notifications (N) in the INSIGHTS menu. The setting persists between TapMap sessions and is independent of MQTT notifications.

Changes

  • Add native desktop notification support for Windows, Linux, and macOS.
  • Show the significance reason, application name, and country in notifications.
  • Add the persistent Notifications (N) toggle under INSIGHTS.
  • Request notification permission on macOS and use the default notification sound.
  • Activate desktop notifications after the application is ready.
  • Show desktop notification availability and current state in About.
  • Keep MQTT and desktop notification channels independent.
  • Add Linux notification dependencies for source and packaged installations.
  • Include the Debian Forky system tray fix from fix: handle PyGObject tray failure on Debian #190.
  • Add desktop notification documentation and update Help, README, Privacy, Architecture, Docker, and environment variable documentation.
  • Add and update tests for notification delivery, settings, lifecycle, keyboard behavior, About, and modal integration.

Testing

Tested desktop notifications manually on Windows, Linux, and macOS.

Packaged Linux and macOS builds were also tested, including system tray behavior and notification delivery.

Final Windows validation:

ruff check .
All checks passed!

pytest
1007 passed, 6 skipped

@olalie
olalie merged commit 1316f36 into main Sep 16, 2026
9 checks passed
@olalie
olalie deleted the feat/desktop-notifications branch September 16, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant