Skip to content

Security dependency updates + fix unbounded XDCC pagination loop - #53

Merged
oldmagic merged 2 commits into
mainfrom
chore/security-updates-2026-11
Nov 1, 2026
Merged

oldmagic merged 2 commits into
mainfrom
chore/security-updates-2026-11

Conversation

@oldmagic

@oldmagic oldmagic commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Security updates

Package From → To Advisories fixed
Pillow 12.3.0 → 13.0.0 59 (6 critical: heap overflows in JPEG/TIFF/FPX, Ghostscript argument injection)
urllib3 2.7.0 → 2.8.0 GHSA-8988-9cw3-xx77 (high), GHSA-vxq7-64xx-v4gw (high), GHSA-gh4c-6fx4-qh6g (moderate)
Werkzeug 3.1.6 → 3.1.9 GHSA-g6x2-hccm-hh4m (moderate)
black 26.3.1 → 26.10.1 GHSA-cg8m-r9f2-5wm2 (high, GitHub Action only)

Also low-risk bumps: requests 2.34.2, cryptography 50.0.2, python-dotenv 1.2.4, tqdm 4.70.1, loguru 0.7.3, pytest 9.2.0.

Compatibility review (release notes checked):

  • Pillow 13 requires Python ≥ 3.11 (Docker image is 3.11). Pillow isn't imported by the app; the removed APIs aren't used.
  • urllib3 2.8 behavior changes affect HTTPS-proxy TLS config and empty Retry.allowed_methods; neither is used (both Retrys use allowed_methods=("GET",)).
  • Flask 3.1.3 requires werkzeug>=3.1.0; requests 2.34.2 requires urllib3<3.

Re-scan against OSV after the bump: 0 known vulnerabilities in pinned packages.

Major-version updates (SQLAlchemy 2.1, Flask-SQLAlchemy 3.1, PlexAPI 4.18, python-dateutil 4, rich 15, httpx 0.28, etc.) are intentionally left for a separate PR.

Bug fix: XDCC pagination could loop forever

search_missing_episode only stopped on an empty page or once total was reached. If the API omitted total and kept returning results, or ignored page, it never terminated. tests/test_xdcc.py hung on main for exactly this reason.

It now stops on a short page (fewer than limit results), when total is reached, or after MAX_PAGES (50 pages, i.e. 10,000 packs). Two regression tests were added.

Testing

In a python:3.11-slim container (matching the Dockerfile):

  • pip install -r requirements.txt and pip check: no conflicts
  • pytest: 3 passed
  • App smoke test: GET / → 200

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T18:44:29.987399Z f992862 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

oldmagic and others added 2 commits November 1, 2026 19:43
- Pillow 12.3.0 -> 13.0.0 (59 advisories incl. critical heap overflows
  and Ghostscript argument injection)
- urllib3 2.7.0 -> 2.8.0 (HTTPS proxy TLS config ignored, unbounded
  chunk-size buffering, chunked deflate infinite loop)
- Werkzeug 3.1.6 -> 3.1.9 (safe_join Windows device names)
- black 26.3.1 -> 26.10.1 (GitHub Action required-version)

Also low-risk patch/minor bumps: requests 2.34.2, cryptography 50.0.2,
python-dotenv 1.2.4, tqdm 4.70.1, loguru 0.7.3, pytest 9.2.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
search_missing_episode only stopped on an empty page or when the
reported total was reached. If the API omits "total" and keeps
returning results (or ignores the page parameter), it looped forever;
the existing unit test hung for this reason.

Stop on a short page, on reaching total, or after MAX_PAGES (50) pages.
Add regression tests for both cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oldmagic
oldmagic force-pushed the chore/security-updates-2026-11 branch from f992862 to 84d548b Compare November 1, 2026 18:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f992862bd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt

# Image processing (for poster/backdrop handling)
Pillow==12.3.0
Pillow==13.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the Pillow pin compatible with Python 3.10

For non-Docker installs on Python 3.10, this pin makes pip install -r requirements.txt fail: Pillow 13 requires Python >=3.11, while the previous 12.3.0 supports Python 3.10. The README still advertises Python 3.7+ and setup.py includes a Python 3.10 classifier, so keep a compatible pin or update the supported-version documentation.

Useful? React with 👍 / 👎.

@oldmagic
oldmagic merged commit 3c7f608 into main Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant