Repository navigation
Security dependency updates + fix unbounded XDCC pagination loop - #53
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- Pillow 12.3.0 -> 13.0.0 (59 advisories incl. critical heap overflows and Ghostscript argument injection) - urllib3 2.7.0 -> 2.8.0 (HTTPS proxy TLS config ignored, unbounded chunk-size buffering, chunked deflate infinite loop) - Werkzeug 3.1.6 -> 3.1.9 (safe_join Windows device names) - black 26.3.1 -> 26.10.1 (GitHub Action required-version) Also low-risk patch/minor bumps: requests 2.34.2, cryptography 50.0.2, python-dotenv 1.2.4, tqdm 4.70.1, loguru 0.7.3, pytest 9.2.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
search_missing_episode only stopped on an empty page or when the reported total was reached. If the API omits "total" and keeps returning results (or ignores the page parameter), it looped forever; the existing unit test hung for this reason. Stop on a short page, on reaching total, or after MAX_PAGES (50) pages. Add regression tests for both cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f992862 to
84d548b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f992862bd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # Image processing (for poster/backdrop handling) | ||
| Pillow==12.3.0 | ||
| Pillow==13.0.0 |
There was a problem hiding this comment.
Keep the Pillow pin compatible with Python 3.10
For non-Docker installs on Python 3.10, this pin makes pip install -r requirements.txt fail: Pillow 13 requires Python >=3.11, while the previous 12.3.0 supports Python 3.10. The README still advertises Python 3.7+ and setup.py includes a Python 3.10 classifier, so keep a compatible pin or update the supported-version documentation.
Useful? React with 👍 / 👎.
Security updates
Also low-risk bumps: requests 2.34.2, cryptography 50.0.2, python-dotenv 1.2.4, tqdm 4.70.1, loguru 0.7.3, pytest 9.2.0.
Compatibility review (release notes checked):
Retry.allowed_methods; neither is used (bothRetrys useallowed_methods=("GET",)).werkzeug>=3.1.0; requests 2.34.2 requiresurllib3<3.Re-scan against OSV after the bump: 0 known vulnerabilities in pinned packages.
Major-version updates (SQLAlchemy 2.1, Flask-SQLAlchemy 3.1, PlexAPI 4.18, python-dateutil 4, rich 15, httpx 0.28, etc.) are intentionally left for a separate PR.
Bug fix: XDCC pagination could loop forever
search_missing_episodeonly stopped on an empty page or oncetotalwas reached. If the API omittedtotaland kept returning results, or ignoredpage, it never terminated.tests/test_xdcc.pyhung onmainfor exactly this reason.It now stops on a short page (fewer than
limitresults), whentotalis reached, or afterMAX_PAGES(50 pages, i.e. 10,000 packs). Two regression tests were added.Testing
In a
python:3.11-slimcontainer (matching the Dockerfile):pip install -r requirements.txtandpip check: no conflictspytest: 3 passedGET /→ 200🤖 Generated with Claude Code