Skip to content

fix: avoid temporary file locking on Windows tests #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GouravGC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid temporary file locking on Windows tests #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ def test_client_generate_images(httpserver: HTTPServer):

client = Client(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as temp:
with tempfile.NamedTemporaryFile(delete=False) as temp:
temp.write(PNG_BYTES)
temp.flush()
response = client.generate('dummy', 'Why is the sky blue?', images=[temp.name])
Expand Down Expand Up @@ -851,7 +851,7 @@ def test_client_create_blob(httpserver: HTTPServer):

client = Client(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as blob:
with tempfile.NamedTemporaryFile(delete=False) as blob:
response = client.create_blob(blob.name)
assert response == 'sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'

Expand All @@ -861,7 +861,7 @@ def test_client_create_blob_exists(httpserver: HTTPServer):

client = Client(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as blob:
with tempfile.NamedTemporaryFile(delete=False) as blob:
response = client.create_blob(blob.name)
assert response == 'sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'

Expand Down Expand Up @@ -1056,7 +1056,7 @@ async def test_async_client_generate_images(httpserver: HTTPServer):

client = AsyncClient(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as temp:
with tempfile.NamedTemporaryFile(delete=False) as temp:
temp.write(PNG_BYTES)
temp.flush()
response = await client.generate('dummy', 'Why is the sky blue?', images=[temp.name])
Expand Down Expand Up @@ -1228,7 +1228,7 @@ async def test_async_client_create_blob(httpserver: HTTPServer):

client = AsyncClient(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as blob:
with tempfile.NamedTemporaryFile(delete=False) as blob:
response = await client.create_blob(blob.name)
assert response == 'sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'

Expand All @@ -1238,7 +1238,7 @@ async def test_async_client_create_blob_exists(httpserver: HTTPServer):

client = AsyncClient(httpserver.url_for('/'))

with tempfile.NamedTemporaryFile() as blob:
with tempfile.NamedTemporaryFile(delete=False) as blob:
response = await client.create_blob(blob.name)
assert response == 'sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'

Expand Down
4 changes: 2 additions & 2 deletions tests/test_type_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ def test_image_serialization_plain_string():


def test_image_serialization_path():
with tempfile.NamedTemporaryFile() as temp_file:
with tempfile.NamedTemporaryFile(delete=False) as temp_file:
temp_file.write(b'test file content')
temp_file.flush()
img = Image(value=Path(temp_file.name))
assert img.model_dump() == b64encode(b'test file content').decode()


def test_image_serialization_string_path():
with tempfile.NamedTemporaryFile() as temp_file:
with tempfile.NamedTemporaryFile(delete=False) as temp_file:
temp_file.write(b'test file content')
temp_file.flush()
img = Image(value=temp_file.name)
Expand Down