fix(browsers): disable hardware video decode on Chromium-family browsers - #418
Open
duketopceo wants to merge 1 commit into
Open
duketopceo wants to merge 1 commit into
duketopceo wants to merge 1 commit into
Conversation
On Apple Silicon the VA-API path decodes through the AVD driver, which renders green frames on a subset of streams. The shipped --disable-accelerated-video-decode switch is a ChromeOS-era toggle that no Linux decode path reads — current Chromium gates decoder creation solely on the AcceleratedVideoDecoder feature, enabled by default in builds with VA-API (Brave, Brave Origin) and compiled out of Arch's chromium package. Add --disable-features=AcceleratedVideoDecoder to the shared flags file omarchy-install-browser copies into every browser's *-flags.conf, and a migration that merges it into flag files already on disk (extending any existing --disable-features list rather than shadowing it). Native players still use AVD via libva; only browser decode drops to software. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
wesleygrimes
added
the
defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Omarchy-side half of #388 / #370.
On Apple Silicon, browser hardware video decode runs through the AVD driver via
libva-v4l2_request-avd— and renders green frames on a subset of streams. A prior shipped workaround used--disable-accelerated-video-decode, but that switch is dead on Linux: in Chromium 152 (content/public/common/content_switches.cc) it's documented as ChromeOS-only policy plumbing, and the actual decoder gate —GetPreferredLinuxDecoderImplementation()inmedia/mojo/services/gpu_mojo_media_client_linux.cc— checks only theAcceleratedVideoDecoderfeature. That's enabled by default in builds with VA-API (Brave, Brave Origin — matching the reporters'stringsfindings) and compiled out of Arch'schromium, which is why stock Chromium never shows the bug.Changes:
config/chromium-flags.confgains--disable-features=AcceleratedVideoDecoder.omarchy-install-browseralready copies this file into every browser's*-flags.conf(chromium, chrome, brave, brave-origin, edge), so one line covers the whole family. On VA-API-less builds it's a no-op; native players (mpv/ffmpeg/GStreamer) keep full AVD decode — only browsers drop to software.1789045438.shmerges the flag into~/.config/*-flags.conffiles already on disk — extending an existing--disable-features=list instead of shadowing it (a repeated flag would replace, not combine).Test plan
test/shell.d/chromium-avd-decode-test.sh: append, merge-into-existing-list, idempotence, multi-browser coverage, no-op — 5/5 pass152.0.7977.75(the version in ALARM repos)--dump-domsmoke test)Generated with Devin