Strip CAP_SYS_ADMIN from gsr-kms-server and avoid its pkexec fallback - #11716
Closed
Chessing234 wants to merge 1 commit into
Closed
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Arch grants the helper a root-equivalent capability; drop it on install/upgrade and prefer portal capture when the capability is absent so recording does not escalate through pkexec.
Contributor
Author
|
@ryanrhughes @kwilczynski strips cap_sys_admin from gsr-kms-server — security review appreciated |
3 tasks
Contributor
Author
|
folded into #12103 — same cap-strip hooks/tests, one review is enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu-screen-recorderpackage grantsgsr-kms-serverCAP_SYS_ADMIN, which is root-equivalent and world-executable (gsr-kms-serverships withcap_sys_admin(root-equivalent capability) #8245).OMARCHY_SCREENRECORD_USE_KMS=truecan force KMS after restoring the capability).Test plan
bash test/shell.d/gsr-kms-caps-test.shgetcap /usr/bin/gsr-kms-serveris empty after update; screen recording still starts via portalFixes #8245