Conversation
bdcded6 to
141feaf
Compare
|
Ran this on Omarchy 4.0.4 (fcitx5 5.1.22, Hyprland 0.56.2) against an install that already had Mozc registered: idempotent, exit 0, no group rewrite. The D-Bus registration is the right call — editing Two small things from using it, plus one gap that bites right after it succeeds.
if fcitx5-remote --check >/dev/null 2>&1; then#11719 hit the same thing in the Korean sibling.
Chromium ignores the IME unless Unrelated to the setup path, for anyone who finds this thread: once input works in Chromium, the candidate window is misplaced there (#7559), and the popup is invisible in Hyprland true fullscreen (#11303). For what it is worth, the shape of this PR — one menu action, engine named rather than language — reads right. A sibling |
|
@akitaonrails Thank you so much for testing this on your setup and taking the time to write such detailed feedback! It’s especially helpful to have confirmation that running it with Mozc already registered leaves the group unchanged. I’ve addressed both points in f903b4e:
I also updated the test to catch the stray output. The related shell tests and CLI suite pass. Thanks as well for opening #12139 and pointing out the related issues and theme integration. I really appreciate you looking beyond setup to what people encounter when they start using Japanese input. |
default/omarchy/launcher.hides:11 hides fcitx5-configtool, so both the manual section and the setup command's closing message pointed at a GUI that never shows up in the launcher after installing it. Name the terminal instead. Found by @akitaonrails while reviewing the Japanese sibling, omacom#9634.
Summary
fcitx5-mozc, restart Fcitx 5, and append Mozc to the current input-method groupWhy
Japanese input is not optional for Japanese-speaking users. Windows and macOS finish setup with a working Japanese IME, while Omarchy currently requires users to discover the package and configure Fcitx 5 manually.
This keeps the first change deliberately small: it adds a one-step setup action rather than changing the main installer.
Scope
This PR intentionally treats input-method setup separately from locale and UI internationalization. These concerns may be connected during initial setup, but users may need Japanese input regardless of their system locale or UI language.
Keeping this change focused also makes it possible to improve the input experience incrementally without first deciding the broader locale and i18n architecture.
Naming the menu item after the input engine rather than equating Japanese input with Mozc also leaves room to add options such as Hazkey (Japanese) or Rime (Chinese) alongside it in the future.
Testing
bash test/shell.d/input-japanese-test.shbash test/shell.d/menu-test.shbash test/shell.d/menu-guards-test.sh./test/clinihongoto日本語in a real terminalThe broader VM suite still has unrelated existing environment/OCR failures; the new Japanese input acceptance test passes end to end.