[feat] Add bridged networking with offline startup and adapter recovery - #198
Merged
Merged
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Adds a Networking sheet to the launcher with Shared connection (NAT), the default, and Bridged networking through a selected host adapter. Bridged mode gives the VM its own LAN address while keeping QEMU unprivileged; a bundled, signed networking helper receives one-time macOS approval.
The selected adapter can be absent at launch: Omarchy starts offline, retains the selection, and connects when it returns. Dock or Ethernet disconnects recreate the bridge attachment while preserving the VM's connection. The launcher uses neutral mode labels and an informational offline-start notice.
Saved NAT port-forwarding rules remain stored but inactive while bridged. LAN SSH access is a separate opt-in. Wi-Fi compatibility handling is disclosed in the sheet and restored when the session ends. Only one bridged session is allowed at a time.
Implementation
Validation
Manual tests on the local integration build containing this networking implementation:
Automated validation on this isolated upstream branch: full
make test(261 Swift tests plus guest, shell, C, and Python suites), including native networking policy, helper framing/recovery, stale payload, and launcher contract tests; signed app build and bundled Mach-O compatibility checks. The QEMU runtime was built from the current pinned upstream scripts for macOS 15. The app build reuses the existing factory guest artifact; it is not a fresh factory-image build.Remaining release qualification
Developer ID signing/notarization and helper registration upgrade/relocation need release-environment qualification. One unattended Thunderbolt test showed a temporary latency excursion that recovered; its cause remains unestablished. A separate user-mode NAT ICMP reply-association issue is outside this PR; no NAT runtime fix is included.
Implementation limitations for review: helper connection verification is synchronous and can pause the launcher while waiting; the carrier watcher is cleaned up with the VM but is not automatically restarted after an unexpected exit.
UI screenshots
Screenshots from the tested local integration build. Surrounding launcher settings may differ from upstream; these illustrate the networking controls and offline-start notice.
Shared connection (NAT)
Shared connection (NAT) remains the default and uses the Mac’s connection.
Bridged networking
Bridged mode provides adapter selection and a separate opt-in for LAN SSH access. Wi-Fi compatibility handling is explained before saving.
Offline startup
An unavailable adapter does not block startup. Omarchy starts offline and connects when the selected adapter returns.