Fix password prompts for theme and DNS menu actions - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching themes or selecting a stock DNS provider currently falls back to a polkit password dialog because the factory image omits upstream's scoped sudoers grants. Install
omarchy-dnsandomarchy-theme-browserunchanged from the pinned Omarchy 4.0.3 source, with mode0440, and include them intry-omarchy-runtime.The grants cover only Cloudflare/Google/DHCP and the browser policy helper with a six-digit lowercase hex color. Custom DNS and unrelated sudo operations retain their existing authentication. Factory finalization checks sudoers syntax, root ownership, permissions, and package ownership.
This applies to new/reset VMs. Replacing the Mac app does not modify an existing guest; the guest documentation makes that limitation explicit.
Closes #214.
Validation
make testpassed.guest/test --source /private/tmp/try-omarchy-214-sourcepassed against the pinned commit and release tag, including exact policy bytes and mode checks.visudo -cf.bash macos/Tests/run-qemu-ssh-contract.test.shpassed after rebasing onto current main.make guestbuilt the pinned ABI packages, then stopped before rootfs staging because the live package transaction differs from the committed lock:libadwaita1:1.9.3-1 → 1:1.9.4-1,libde2651.1.2-1 → 1.1.3-1,libtirpc1.3.7-1 → 1.3.8-1,linux-aarch64and headers 7.2.5-1 → 7.2.6-1,qt6-declarative6.11.2-1 → 6.11.2-2, andtzdata2026c-1 → 2026d-1. No package pins were changed for this fix. Full image/package-ownership validation and a live guest menu smoke test remain unverified.