Skip to content

[Geolocation] sizes of anchors not consistent between portrait and landscape #134

Description

@nickw1

Steps to Reproduce

Run the geolocation demo app initially in landscape mode and then in portrait, you'll note the demo anchors appear larger in portrait compared to landscape.

This is due, I believe, to mismatches in the aspect ratio and field of view in landscape compared to portrait - see LocAR.js issue 35 (AR-js-org/locar.js#35).

This is, I believe, fixed in Locar but the fix is not applied yet to RDK. Locar versions 0.2.9, 0.2.10 and 0.2.11 exposes new methods to make it easier to hook into this code from RDK.

I have done some experiments with RDK in hooking into this 0.2.9 - 0.2.11 functionality - but having limited success so far - possibly due to the canvas being provided by R3F rather than locally, but this needs to be investigated further. See https://github.com/nickw1/rdk/commits/fov-match-camera/
In portrait, the anchors scale better but are upside down - this does not happen in plain LocAR.

I may be able to investigate this further but a bit shorter on time now - so raising it here as an issue.

Expected Behavior

Anchors should be consistent in size between landscape and portrait

Actual Behavior

See above.

Environment

No response

Additional Notes/Screenshots

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions