feat: add S-Learner, T-Learner, and X-Learner implementations with ut…#39
Merged
Conversation
…ility functions Also -- make sure sklearn indexes SliceDict with pandas indexing if values are pandas otherwise non-default index will cause unexpected behavior
jwdink
requested changes
Jul 8, 2026
jwdink
left a comment
jwdink
left a comment
Contributor
There was a problem hiding this comment.
can you bump the version and do a quick addition of type-hints where it's easy to do so? then g2g
|
|
||
| return yhat_t - yhat_c | ||
|
|
||
| def score(self, X, y, sample_weight=None, method='qini', normalize=True, **kwargs) -> float: |
Contributor
Author
There was a problem hiding this comment.
done. TIL about @overload
…dict methods feat: bump version
jwdink
approved these changes
Jul 8, 2026
Co-authored-by: Jacob <6982295+jwdink@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ility functions
Also -- make sure sklearn indexes SliceDict with pandas indexing if values are pandas otherwise non-default index will cause unexpected behavior
@jwdink -- This branch was created based on the
feature/upliftbranch which included too many older commits that appeared unrelated to uplift modeling. See draft PR 38