Skip to content

feat: ✨ stage basic raw data#108

Draft
martonvago wants to merge 17 commits into
mainfrom
feat/raw-to-staging-basic
Draft

feat: ✨ stage basic raw data#108
martonvago wants to merge 17 commits into
mainfrom
feat/raw-to-staging-basic

Conversation

@martonvago

@martonvago martonvago commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR stages raw data that does not require special transformations (like, e.g., VAS data).
I split this into a separate PR because we are already handling repeating and non-repeating resources, so that's enough complexity.

This works only with #106.
It ran fine on the newest version of the real data and metadata on GenomeDK.

Closes #109

This PR needs an in-depth review.

Checklist

  • Ran just run-all

Comment thread scripts/form_event.json

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mapping tells us what forms/resources are filled in at which events. We can use it to select relevant rows for each resource when staging data.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar addition as in #106. It might make sense to pull out common logic once both are merged.

@martonvago martonvago moved this from Todo to In review in Data development Jun 15, 2026
@martonvago martonvago mentioned this pull request Jun 15, 2026
1 task
@martonvago
martonvago marked this pull request as ready for review June 15, 2026 15:06
@martonvago
martonvago requested a review from a team as a code owner June 15, 2026 15:06

@lwjohnst86 lwjohnst86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've written in other PRs, there's not enough clarity about what data gets converted into what resource. I think we need to take a step back and write some docs to make that link clearer. Plus, as @joelostblom suggested, wrangle data first without using/depending on the data dictionary, and only after we've created them into staging/ will we extract the properties from them and link them to the data dictionary. I'm going to convert this to draft for now.

@lwjohnst86
lwjohnst86 marked this pull request as draft June 22, 2026 13:11
@lwjohnst86 lwjohnst86 moved this from In review to In progress in Data development Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Stage forms that need no special transformations

2 participants