Repository navigation
chore(docs): run on ViteHub main db9f307 - #39
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tinyaml
tinyini
tinyjson5
tinylinkify
tinyswap
commit: |
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 findings remain.
Approach: sound — the dependency upgrade aligns Content with its supported Comark stack, while explicitly disabling Content’s added preset preserves the site’s existing rendering configuration.
Reviewed changes — reviewed all four changed files and traced their effects through Markdown parsing, prerendering, client navigation, and Cloudflare serving.
- Dependency alignment: pins ViteHub Content to
db9f307and updates Comark, Comark Content, Comark UI/icon, and Shiki while retaining the locked Nuxt nightly. - Preset preservation: keeps the site’s custom plugin ordering and prevents Content’s defaults from restoring chips or typesetting.
- Install configuration: removes the obsolete parser override, unused native-package build permissions, and old release-age exclusions; allows the preview packages’ transitive tarball URLs.
- Lockfile regeneration: removes the unused ViteHub dependency graph; tinyaml retains its existing Comark/chart versions with an updated Shiki peer resolution, which passed a focused SVG-generation smoke test.
Validation passed: pnpm install --frozen-lockfile, pnpm docs:generate, production-worker route/content-type/redirect checks, and browser checks for navigation, code tabs, copying, and image zoom. The build produced all 24 pages, and generated internal links and heading anchors resolved successfully.
gpt-6.1-sol(xhigh) | 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. |

The docs site was on
@vite-hub/content0.1.0, about 1,380 commits behind ViteHub main, with a Comark 0.8 stack held together by an override. This moves it to the pkg.pr.new build of ViteHub main at db9f307 (after v0.2.0, which is not on npm yet) and the Comark versions Content uses there. The pages come out the same.What changes:
@vite-hub/contentpins db9f307.comarkand@comark/htmlgo to ^0.9,comark-uiandcomark-iconto ^0.12,comark-contentto 0.5.1 (the version Content pins), andshikito ^4.6 (comark 0.9's peer range).defineContent()on main adds its own Comark UI preset in front ofmarkdown.plugins(feat(docs): read pages through content.get() with one parser config vite-hub/vitehub#4143), which would bringchipsandtypesetback.markdown: { preset: false, plugins }keeps the site's own preset as the only one.comark-content>comarkoverride goes: comark-content 0.5.1 asks for comark 0.9 itself.@mongodb-js/zstd,@swc/core,cbor-extract,cpu-features,msgpackr-extract,node-liblzma,ssh2). TheirallowBuildsentries and the release-age excludes for ViteHub 0.1.0 and Comark 0.8 go with them.blockExoticSubdeps: false, since the pkg.pr.new tarballs depend on each other by URL.The Nuxt nightly stays at the locked 5.0.0-2611081128-d54cab9 and the library packages' lockfile entries don't change.
What I ran, Node 24.21.0 on Linux:
pnpm install --frozen-lockfilepasses.pnpm docs:generateonmainand on this branch, then compareddocs/dist/public. The same 115 files outside_nuxt/and the same 24 pages. Every.mdcopy,search.json,llms.txtand_headersis byte-identical. The visible text of 23 pages is identical. On/tinylinkify/compatibility/, the baregithub.comin prose is no longer a link: comark 0.9 follows GFM there, which only links a domain withwww.or a scheme. The rest of the HTML diff is Comark UI 0.12's CSS and code-block script. Code lines (174) and links otherwise match, and no chips or typeset markup shows up.wrangler@4.158.0 dev -c docs/dist/server/wrangler.json:/,/tinyaml/guide/getting-started/,/tinylinkify/compatibility/,/search.json,/llms.txt,/index.md,/tinyaml/guide/api.mdanswer 200 with the right content types,Accept: text/markdownon/answers Markdown,/nope/404, andHost: tinyaml.onmax.me301s tohttps://tiny.onmax.me/guide/.pnpm docs:devfails with "Unrecognized import attributes specified" on every page, onmainas well. I think it's@iconify-json/lucide, which imports its JSONwith { type: 'json' }and goes through the Cloudflare dev runner, but I didn't confirm it. This PR doesn't change that.Workers Builds deploys on merge. After that,
curl -sI https://tinyaml.onmax.me/guide/should still 301.